Skip to content

fix(github-action): unit-test coverage checks#153

Merged
cheyang merged 1 commit intosgl-project:mainfrom
Syspretor:fix/unit-test-check
Jan 30, 2026
Merged

fix(github-action): unit-test coverage checks#153
cheyang merged 1 commit intosgl-project:mainfrom
Syspretor:fix/unit-test-check

Conversation

@Syspretor
Copy link
Copy Markdown
Collaborator

@Syspretor Syspretor commented Jan 27, 2026

Ⅰ. Motivation

Ⅱ. Modifications

Ⅲ. Does this pull request fix one issue?

fixes #XXXX

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

@gemini-code-assist
Copy link
Copy Markdown

gemini-code-assist Bot commented Jan 27, 2026

Summary of Changes

Hello @Syspretor, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the robustness of the LeaderWorkerSetReconciler by ensuring that RolloutStrategy configurations, particularly RollingUpdate parameters like Partition, are accurately detected and applied. The changes enable the reconciler to properly react to modifications in rollout strategies, facilitating correct updates and reconciliation cycles for LeaderWorkerSet resources.

Highlights

  • Rolling Update Logic Refinement: Refined the LeaderWorkerSetReconciler's logic for constructing LeaderWorkerSet apply configurations, specifically improving how RollingUpdate strategies are processed from both role-level and coordination-level specifications. This ensures that coordination-level parameters are applied correctly even when role-level strategies are absent.
  • Rollout Strategy Comparison: Enhanced the lwsSpecEqual function to perform a deep comparison of RolloutStrategy fields. This critical change ensures that modifications to rollout strategies (e.g., Partition values) are correctly detected, thereby triggering necessary reconciliation cycles.
  • New Unit Tests: Added two new unit tests: TestLwsSpecEqual_RolloutStrategyDiff to validate the RolloutStrategy comparison, and TestConstructLWSApplyConfiguration_CoordinationRollingUpdate to verify the correct application of coordination-level rolling update parameters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/project-check.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces necessary fixes for handling RolloutStrategy in LeaderWorkerSet reconciliation, ensuring that changes in rollout strategy, particularly partition updates, are correctly detected and applied. The code refactoring to use boolean flags for checking the existence of rolling update configurations improves readability and prevents potential nil pointer dereferences. Additionally, comprehensive unit tests have been added to validate these changes, which is a significant improvement for code robustness.

Comment thread pkg/reconciler/lws_reconciler.go Outdated
Comment on lines +455 to +457
if !reflect.DeepEqual(lws1.RolloutStrategy, lws2.RolloutStrategy) {
return false, fmt.Errorf("RolloutStrategy not equal")
}
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The error message "RolloutStrategy not equal" is a bit generic. To improve debuggability, it would be beneficial to provide more specific details about what part of the RolloutStrategy caused the inequality, similar to how other lwsSpecEqual checks provide more context (e.g., leaderWorkerTemplate not equal). This would help in quickly identifying the root cause of reconciliation issues.

@Syspretor Syspretor force-pushed the fix/unit-test-check branch from 99fc888 to f72bf76 Compare January 27, 2026 11:51
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Syspretor Syspretor force-pushed the fix/unit-test-check branch 3 times, most recently from 7323c56 to b940b59 Compare January 28, 2026 10:07
@Syspretor Syspretor force-pushed the fix/unit-test-check branch from b940b59 to 58e07b1 Compare January 30, 2026 02:16
cheyang
cheyang approved these changes Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang cheyang merged commit a5ed7a4 into sgl-project:main Jan 30, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Syspretor @codecov-commenter @cheyang