chore(rbg): add envtest#145
Merged
Syspretor merged 2 commits intosgl-project:mainfrom Jan 22, 2026
Merged
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds envtest support to the rbg project by vendoring the controller-runtime testing infrastructure and related Kubernetes client packages. This enables integration testing capabilities for Kubernetes controllers.
Changes:
- Deleted the volcano.sh/apis LICENSE file from vendor directory
- Added controller-runtime internal testing packages (envtest, controlplane, process, certs, addr, flock)
- Added k8s.io/apiextensions-apiserver client packages for CRD management
- Updated vendor/modules.txt to reflect the new dependencies
Reviewed changes
Copilot reviewed 12 out of 97 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/volcano.sh/apis/LICENSE | Removed Apache 2.0 license file |
| vendor/sigs.k8s.io/controller-runtime/pkg/internal/testing/* | Added testing infrastructure packages (process, controlplane, certs, addr) |
| vendor/sigs.k8s.io/controller-runtime/pkg/internal/flock/* | Added file locking utilities for port management |
| vendor/sigs.k8s.io/controller-runtime/pkg/envtest/* | Added envtest package for integration testing |
| vendor/k8s.io/apiextensions-apiserver/pkg/client/* | Added CRD client packages (v1, v1beta1, scheme) |
| vendor/modules.txt | Updated to include new vendored packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Syspretor
force-pushed
the
chore/add-env-test
branch
2 times, most recently
from
dde3928 to
c587af1
Compare
Syspretor
force-pushed
the
chore/add-env-test
branch
2 times, most recently
from
40f4074 to
5646761
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Syspretor
force-pushed
the
chore/add-env-test
branch
6 times, most recently
from
c8985ed to
3ab6d7c
Compare
Collaborator
|
@Syspretor please fix the lint issue: Error: test/envtest/testutil/setup.go:27:2: should not use dot imports (ST1001)
Error: test/envtest/testutil/setup.go:28:2: should not use dot imports (ST1001) |
Syspretor
force-pushed
the
chore/add-env-test
branch
9 times, most recently
from
297624e to
06d1e6f
Compare
Syspretor
force-pushed
the
chore/add-env-test
branch
from
06d1e6f to
4f81b4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
fixes #XXXX
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.