Skip to content

fix(rbg): fix instanceset rbac and lws env build#116

Merged
cheyang merged 1 commit intosgl-project:mainfrom
Syspretor:chore/add-instanceset-controller-rbac
Dec 2, 2025
Merged

fix(rbg): fix instanceset rbac and lws env build#116
cheyang merged 1 commit intosgl-project:mainfrom
Syspretor:chore/add-instanceset-controller-rbac

Conversation

@Syspretor
Copy link
Copy Markdown
Collaborator

Ⅰ. Motivation

  1. Add instanceSet related rbac
  2. Fix LWS env builder logic

Ⅱ. Modifications

Ⅲ. Does this pull request fix one issue?

fixes #XXXX

Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅴ. Describe how to verify it

VI. Special notes for reviews

Checklist

  • Format your code make fmt.
  • Add unit tests or integration tests.
  • Update the documentation related to the change.

@Syspretor Syspretor requested a review from cheyang December 2, 2025 02:42
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@Syspretor Syspretor marked this pull request as draft December 2, 2025 02:43
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Syspretor Syspretor force-pushed the chore/add-instanceset-controller-rbac branch from b80a55b to c111329 Compare December 2, 2025 02:50
@Syspretor Syspretor marked this pull request as ready for review December 2, 2025 02:51
Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cheyang cheyang merged commit 0939ba8 into sgl-project:main Dec 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants