fix(rbg): fix incorrect apiVersion in auto-generated applyconfigurations#101
Merged
cheyang merged 1 commit intosgl-project:mainfrom Nov 17, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect apiVersion values in auto-generated Kubernetes client code by adding the required // +groupName=workloads.x-k8s.io directive to the API package's doc.go file. This ensures code generators produce the correct fully-qualified group name instead of the shortened form.
Key changes:
- Added doc.go file with the
// +groupName=workloads.x-k8s.iodirective to specify the correct API group name - Regenerated client-go code with corrected apiVersion from
workloads/v1alpha1toworkloads.x-k8s.io/v1alpha1
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| api/workloads/v1alpha1/doc.go | Added new file with groupName directive to fix code generation |
| client-go/applyconfiguration/workloads/v1alpha1/*.go | Corrected apiVersion in apply configuration constructors (6 files) |
| client-go/applyconfiguration/utils.go | Updated comment to reflect correct group name |
| client-go/informers/externalversions/generic.go | Updated comment to reflect correct group name |
| client-go/clientset/versioned/typed/workloads/v1alpha1/workloads_client.go | Updated comment to reflect correct group name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Syspretor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Motivation
Ensure the generated client code has the correct apiVersion by declaring
// +groupName=workloads.x-k8s.ioin the doc.go file.Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.