Checklist
Motivation
Align with LWS controller behaviour, which copy annotations with volcano.sh/ prefix from lws to pod group
Related resources
LWS controller inherits annotations from lws resource. However, rbg controller would not copy.
https://github.com/kubernetes-sigs/lws/blob/aa903eeb203252c92ee468f3bf335e0732b1bcb1/pkg/schedulerprovider/volcano_provider.go#L59-L68
https://github.com/kubernetes-sigs/lws/blob/aa903eeb203252c92ee468f3bf335e0732b1bcb1/pkg/schedulerprovider/volcano_provider.go#L111-L119
As you can observe, no annotation would be added.
|
podGroup := &volcanoschedulingv1beta1.PodGroup{ |
|
ObjectMeta: metav1.ObjectMeta{ |
|
Name: rbg.Name, |
|
Namespace: rbg.Namespace, |
|
OwnerReferences: []metav1.OwnerReference{ |
|
*metav1.NewControllerRef(rbg, utils.GetRbgGVK()), |
|
}, |
|
}, |
|
Spec: volcanoschedulingv1beta1.PodGroupSpec{ |
|
MinMember: int32(rbg.GetGroupSize()), |
|
Queue: queue, |
|
PriorityClassName: priorityClassName, |
|
}, |
|
} |
Checklist
Motivation
Align with LWS controller behaviour, which copy annotations with
volcano.sh/prefix fromlwstopod groupRelated resources
LWScontroller inherits annotations fromlwsresource. However,rbgcontroller would not copy.https://github.com/kubernetes-sigs/lws/blob/aa903eeb203252c92ee468f3bf335e0732b1bcb1/pkg/schedulerprovider/volcano_provider.go#L59-L68
https://github.com/kubernetes-sigs/lws/blob/aa903eeb203252c92ee468f3bf335e0732b1bcb1/pkg/schedulerprovider/volcano_provider.go#L111-L119
As you can observe, no annotation would be added.
rbg/pkg/scheduler/volcano/manager.go
Lines 102 to 115 in bd6296e