Checklist
Describe the bug
When use instance workload, after setting RecreateInstanceOnPodRestart to the instance, controller would not recreate the failed instance once one pod is failed or deleted.
The reason why is the RestartPolicy not cited in instance controller, therefore, the instance controller can not recognize this policy.
https://github.com/sgl-project/rbg/blob/main/api/workloads/v1alpha1/instance_types.go#L39
Reproduction
Construct a rbg with instance workload, and set the size of the instance to more than one. And try to delete one pod, the other pods in the same instance will not restart nor be recreated, which is unexpected.
Environment
latest version, v0.6.0
Checklist
Describe the bug
When use instance workload, after setting
RecreateInstanceOnPodRestartto the instance, controller would not recreate the failed instance once one pod is failed or deleted.The reason why is the
RestartPolicynot cited in instance controller, therefore, the instance controller can not recognize this policy.https://github.com/sgl-project/rbg/blob/main/api/workloads/v1alpha1/instance_types.go#L39
Reproduction
Construct a rbg with instance workload, and set the size of the instance to more than one. And try to delete one pod, the other pods in the same instance will not restart nor be recreated, which is unexpected.
Environment
latest version, v0.6.0