Skip to content

Donations CTA modal#635

Merged
mpretty-cyro merged 15 commits into
session-foundation:devfrom
mpretty-cyro:feature/donation-ctas
Nov 28, 2025
Merged

Donations CTA modal#635
mpretty-cyro merged 15 commits into
session-foundation:devfrom
mpretty-cyro:feature/donation-ctas

Conversation

@mpretty-cyro

Copy link
Copy Markdown
Collaborator

No description provided.

@mpretty-cyro mpretty-cyro self-assigned this Nov 19, 2025
@mpretty-cyro mpretty-cyro added enhancement New feature or request Jira This ticket is being tracked in Jira labels Nov 19, 2025
@mpretty-cyro mpretty-cyro changed the title Donations CTA modal [WIP] Donations CTA modal Nov 19, 2025
• Made donations value survive account clearing
• Updated code so providing a good review can bypass the 7 day install limit before the donations CTA is shown
• Localised strings and added hero image
@mpretty-cyro mpretty-cyro changed the title [WIP] Donations CTA modal Donations CTA modal Nov 24, 2025
@mpretty-cyro
mpretty-cyro marked this pull request as ready for review November 24, 2025 01:16
• Removed some duplicate code
• Updated number-based dev settings to use a modal instead of inline input field (more user friendly)
• Fixed an aspect ratio issue with the donation cta modal hero image
# Conflicts:
#	Session.xcodeproj/project.pbxproj
#	Session/Settings/DeveloperSettings/DeveloperSettingsProViewModel.swift
• Tweaked the way gesture recognisers were setup in the message bubbles so they can now be based on the message type rather than the cell type
• Fixed an annoying duplicate symbols build issue caused by the libSession build script
• Fixed a bug with the styling of quotes
• Fixed a bug where quotes that were missing author information could incorrectly show "You" as the author
• Fixed an issue where the "Session Pro" menu item was visible when the feature was disabled (not currently connected to anything)
• Fixed an issue where the disabled message input box wouldn't show errors correctly
• Fixed an issue where message requests received via a community wouldn't result in the message request banner appearing
• Fixed an issue where long pressing on a link in a message would show both the open link modal and the long press menu
• Fixed an issue where outgoing voice messages wouldn't play correctly (incorrectly considered invalid attachments)
• Fixed an issue where you couldn't paste images directly into the message input
• Fixed an issue where mentions wouldn't be visible to the accessibility inspector
• Fixed an issue where mentions could incorrectly result in the text being rendered in RTL
• Fixed an issue where file info wasn't being displayed on the attachment prep screen
• Fixed an issue where tapping the send button would dismiss the keyboard
• Fixed an issue where filtering mentions wasn't working
@mpretty-cyro
mpretty-cyro merged commit 79071a4 into session-foundation:dev Nov 28, 2025
1 check was pending
@mpretty-cyro
mpretty-cyro deleted the feature/donation-ctas branch November 28, 2025 04:22
This was referenced Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Jira This ticket is being tracked in Jira

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants