Rework input focus behaviours and shift files around#626
Merged
mpretty-cyro merged 8 commits intoNov 27, 2025
Conversation
• Linked up quote clearing • Removed the duplicate link preview loading and UI from the MediaMessageView (just use the input UI now) • Cleaned up how the InputView input types is handled a bit • Fixed an issue where link previews weren't rendering in the share extension
mpretty-cyro
changed the title
mpretty-cyro
added
enhancement
mpretty-cyro
marked this pull request as ready for review
November 3, 2025 01:53
RyanRory
approved these changes
Nov 7, 2025
# Conflicts: # Session.xcodeproj/project.pbxproj
• Fixed a bug where mentions wouldn't work correctly • Fixed a bug where mentions could crash when backspacing • Fixed a bug where determining whether a string was RTL could cause lag • Fixed a bug where the attachment and voice message buttons weren't visible in message requests • Fixed a bug where the scroll to bottom button wouldn't work correctly in some cases
# Conflicts: # Session.xcodeproj/project.pbxproj # Session/Conversations/ConversationViewModel.swift # Session/Conversations/Input View/InputView.swift # Session/Conversations/Message Cells/Content Views/LinkPreviewView.swift # Session/Conversations/Message Cells/VisibleMessageCell.swift # Session/Media Viewing & Editing/MessageInfoScreen.swift # Session/Utilities/MentionUtilities+DisplayName.swift # SessionMessagingKit/Utilities/ProfilePictureView+Convenience.swift # SessionUIKit/Components/ProfilePictureView.swift # SessionUIKit/Components/QuoteView.swift
This was referenced Nov 28, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InputView(and other associated records) intoSessionUIKit