Skip to content

Fixed a number of issues found when debugging image orientation bug#625

Merged
mpretty-cyro merged 2 commits into
session-foundation:devfrom
mpretty-cyro:fix/image-orientation-issue-and-other-bugs
Oct 30, 2025
Merged

Fixed a number of issues found when debugging image orientation bug#625
mpretty-cyro merged 2 commits into
session-foundation:devfrom
mpretty-cyro:fix/image-orientation-issue-and-other-bugs

Conversation

@mpretty-cyro

Copy link
Copy Markdown
Collaborator
  • Added the ability to set the custom file server via env variables for testing
  • Disable image editing on the share extension if there isn't enough RAM available to edit the image (ie. prevent crashes due to insufficient memory)
  • Tweaked image loading to avoid pre-decoding large static images to reduce memory spikes (was crashing the share extension on some devices)
  • Updated link previews to load images using the ImageDataManager
  • Fixed an issue where the file id on the message info screen would include extra info
  • Fixed an issue where sharing a file wouldn't show the preview correctly
  • Fixed an issue where the re-upload job could run when a display picture file was missing
  • Fixed an issue where deleting messages across all devices in Note to Self was using the wrong deletion function
  • Fixed an issue where an invalid database value could result in no attachments being able to be loaded in a conversation
  • Fixed an issue where images with orientation metadata would be incorrectly rotated and letterboxed

• Added the ability to set the custom file server via env variables for testing
• Disable image editing on the share extension if there isn't enough RAM available to edit the image (ie. prevent crashes due to insufficient memory)
• Tweaked image loading to avoid pre-decoding large static images to reduce memory spikes (was crashing the share extension on some devices)
• Updated link previews to load images using the ImageDataManager
• Fixed an issue where the file id on the message info screen would include extra info
• Fixed an issue where sharing a file wouldn't show the preview correctly
• Fixed an issue where the re-upload job could run when a display picture file was missing
• Fixed an issue where deleting messages across all devices in Note to Self was using the wrong deletion function
• Fixed an issue where an invalid database value could result in no attachments being able to be loaded in a conversation
• Fixed an issue where images with orientation metadata would be incorrectly rotated and letterboxed
@mpretty-cyro mpretty-cyro self-assigned this Oct 29, 2025
@mpretty-cyro
mpretty-cyro marked this pull request as ready for review October 29, 2025 21:13
@mpretty-cyro mpretty-cyro changed the title [WIP] Fixed a number of issues found when debugging image orientation bug Fixed a number of issues found when debugging image orientation bug Oct 29, 2025
• Fixed an issue where you couldn't properly include the sides of rectangular images when cropping display pictures
• Fixed an issue where cropping display pictures could result in incorrect crop locations or images not being rendered
@mpretty-cyro
mpretty-cyro merged commit 59e4c59 into session-foundation:dev Oct 30, 2025
1 check failed
@mpretty-cyro
mpretty-cyro deleted the fix/image-orientation-issue-and-other-bugs branch October 30, 2025 23:50
@mpretty-cyro mpretty-cyro mentioned this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants