Skip to content

Correcting misformatted timestamps#3

Closed
ghost wants to merge 1 commit intoservofrom
unknown repository
Closed

Correcting misformatted timestamps#3
ghost wants to merge 1 commit intoservofrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 19, 2014

The timestamps were breaking testing of the Last-Modified header.

@metajack
Copy link
Copy Markdown

This should go upstream.

@ghost ghost closed this Aug 20, 2014
jdm referenced this pull request in jdm/web-platform-tests Jul 5, 2016
Sync up with W3C repo
jdm referenced this pull request in jdm/web-platform-tests Feb 9, 2017
servo-wpt-sync pushed a commit that referenced this pull request Oct 21, 2025
Fixing these tests involved the following updates:
1. Update all grid id refs to masonry.

2. In the row test, update the item.style.expectedRows to
item.style.gridRow. I suspect this was a bad AI suggestion I didn't
catch originally.

3. The min-content/max-content contribution in the block direction
(i.e. row direction) is always the same (which is the block content
contribution). This means that the row test expectations needed to
be updated for all min-content entries to match that of max-content.

The reason the grid test for #3 is different is that test sets both
column and row constraints, which impacts what the rows are sized to.
In this case, we are only constraining the row sizes, so we can end
up with different expectations as a result.

Bug: 343257585
Change-Id: I81f19a30d332eab5e18b7638d98467fbb81cde02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7038202
Commit-Queue: Alison Maher <[email protected]>
Reviewed-by: Kurt Catti-Schmidt <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1532680}
servo-wpt-sync pushed a commit that referenced this pull request Mar 17, 2026
…s#58514)

To "prepare the script element" [1] exits early when the element is disconnected.
In this test, the script element represented by frag_script_2 which logs "inline script #3"
is disconnected in the preceeding script (frag_script_1 / "inline script #2").
Since post-connection steps [2] are executed in the tree order, by the time we are to
"prepare the script element" on frag_script_2 / "inline script #3", the script element is
already disconnected and the script will not be executed.

This test failing in Chrome and Safari but passing in Firefox. After the change, the test
passes in Chrome and Safari and fails in Firefox.

[1] https://html.spec.whatwg.org/multipage/scripting.html#prepare-the-script-element
[2] https://dom.spec.whatwg.org/#concept-node-post-connection-ext
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants