This repository was archived by the owner on Feb 16, 2025. It is now read-only.
Use surfman that has glow instead of GL_gen#255
Open
sagudev wants to merge 2 commits intoservo:mainfrom
Open
Conversation
sagudev
force-pushed
the
glowing_surfman
branch
from
5d2b91d to
2e0ce6f
Compare
3 tasks
sagudev
force-pushed
the
glowing_surfman
branch
from
2e0ce6f to
c9e5a36
Compare
Signed-off-by: sagudev <[email protected]>
sagudev
force-pushed
the
glowing_surfman
branch
from
c9e5a36 to
ade0f62
Compare
mrobinson
reviewed
Jan 14, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Nice! Just a couple comments:
| glow = "0.16" | ||
| raw-window-handle = "0.6" | ||
| surfman = { git = "https://github.com/servo/surfman", rev = "300789ddbda45c89e9165c31118bf1c4c07f89f6", features = [ | ||
| surfman = { git = "https://github.com/servo/surfman", rev = "e78ea1b24e1de57f24fc761186d8e9d9e43d660a", features = [ |
Member
There was a problem hiding this comment.
Can we make a surfman release now?
Member
Author
There was a problem hiding this comment.
I was hoping to get this and land companion PR (this way we can still do revert if something goes wrong) then do release on weekend. See servo/surfman#325 (comment)
Signed-off-by: sagudev <[email protected]>
mrobinson
approved these changes
Jan 20, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Looks good, but let's make the surfman release before landing this. Thank you for all of the hard work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on servo/surfman#321