Skip to content

Add android CI and fix android#331

Merged
sagudev merged 4 commits intoservo:mainfrom
sagudev:android
Feb 3, 2025
Merged

Add android CI and fix android#331
sagudev merged 4 commits intoservo:mainfrom
sagudev:android

Conversation

@sagudev
Copy link
Copy Markdown
Member

@sagudev sagudev commented Feb 2, 2025

We need to ensure that EGL context is current.

Discovered in servo/servo#34328

@sagudev sagudev marked this pull request as draft February 2, 2025 13:58
@sagudev sagudev force-pushed the android branch 3 times, most recently from fca2906 to f9cf83e Compare February 2, 2025 14:28
@sagudev sagudev force-pushed the android branch 2 times, most recently from 4659e9f to 0744a98 Compare February 2, 2025 17:48
Signed-off-by: sagudev <[email protected]>
@sagudev
Copy link
Copy Markdown
Member Author

sagudev commented Feb 2, 2025

I think this is mostly done,
test_newly_created_contexts_are_current failes because we use expect no surface is set to context, but in android context cannot be made current if no surface attached, so we use dummy surfaces hence we fail this test. I think we can remove that part of testing.

as for test_context_creation I think the problem is same as in mozangle

I will update expectations tomorrow.

@sagudev sagudev marked this pull request as ready for review February 3, 2025 05:31
sagudev added a commit to sagudev/servo that referenced this pull request Feb 3, 2025
Signed-off-by: sagudev <[email protected]>
@sagudev sagudev requested review from jschwe and mrobinson February 3, 2025 05:42
@sagudev sagudev added this pull request to the merge queue Feb 3, 2025
Merged via the queue into servo:main with commit a8079ee Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants