Allow failure on glutin platform and minor nits#33
Merged
Conversation
Member
Author
|
May you take a quick look at this and tell me if it compiles fine on windows @vvuk? :) (It definitely should, but I have no way to easily test it actually, and our CI is broken because of aster) |
emilio
force-pushed
the
windows-tidy
branch
2 times, most recently
from
a682507 to
1519437
Compare
We should probably change `Err(&str)` to another type of error...
Also implements the missing methods. Don't know when it was removed on the first place.
This commit updates the tests to the newest rust-layers.
Member
Author
|
Seems like CI is broken again due to aster. I could confirm the build and tests passing on linux and mac, and tested the code used in windows and unimplemented platforms. I also changed the feature test, that was working previously just because I was lucky and the vector I was creating contained the memory from old data (I don't even know how I wanted back in the day to get the texture pixels with Android-specific code shouldn't be affected here, so I'm going to merge this. |
Member
|
Good find on the feature test problem :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should probably change
Err(&str)to another type of error...