Skip to content

Make custom properties animatable#316

Merged
Loirooriol merged 1 commit intoservo:mainfrom
Loirooriol:animatable-custom-properties
Feb 27, 2026
Merged

Make custom properties animatable#316
Loirooriol merged 1 commit intoservo:mainfrom
Loirooriol:animatable-custom-properties

Conversation

@Loirooriol
Copy link
Copy Markdown
Collaborator

@Loirooriol Loirooriol commented Feb 25, 2026 •
edited
Loading

Fixes: #38
Servo PR: servo/servo#42858

@Loirooriol Loirooriol mentioned this pull request Feb 25, 2026
Merged
@Loirooriol Loirooriol force-pushed the animatable-custom-properties branch 2 times, most recently from 4f0895f to 2323e5e Compare February 26, 2026 10:40
@Loirooriol
Copy link
Copy Markdown
Collaborator Author

Loirooriol commented Feb 26, 2026

This also fixes a bug in Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=2019537

@Loirooriol Loirooriol marked this pull request as ready for review February 26, 2026 10:44
@Loirooriol Loirooriol mentioned this pull request Feb 26, 2026
Closed
@servo-wpt-sync servo-wpt-sync mentioned this pull request Feb 26, 2026
Merged
@Loirooriol Loirooriol force-pushed the animatable-custom-properties branch from 2323e5e to 359519e Compare February 26, 2026 20:20
@Loirooriol Loirooriol requested a review from yezhizhen February 26, 2026 20:41
yezhizhen
yezhizhen approved these changes Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@yezhizhen yezhizhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylo/style/properties_and_values/value.rs

Lines 204 to 206 in 9a413b4

#[derive(
Clone, Debug, MallocSizeOf, PartialEq, ToCss, ToComputedValue, ToResolvedValue, ToShmem,
)]

It seems you changed this in upstream but not here:
https://phabricator.services.mozilla.com/D285009

Change to oneline.
#[derive(Clone, Debug, MallocSizeOf, ToCss, ToComputedValue, ToResolvedValue, ToShmem)]

@Loirooriol
Copy link
Copy Markdown
Collaborator Author

Loirooriol commented Feb 27, 2026 •
edited
Loading

The difference is that upstream doesn't derive PartialEq, so rustfmt produces a different number of lines.
The next sync will include https://phabricator.services.mozilla.com/D283449, which will make things the same.

@Loirooriol Loirooriol added this pull request to the merge queue Feb 27, 2026
Merged via the queue into servo:main with commit 2f131eb Feb 27, 2026
5 checks passed
@Loirooriol Loirooriol deleted the animatable-custom-properties branch February 27, 2026 02:27
github-merge-queue bot pushed a commit to servo/servo that referenced this pull request Feb 27, 2026
@Loirooriol
build(deps): bump Stylo to "Make custom properties animatable" (#42858)
ee40ecd 
Bumps Stylo to servo/stylo#316

Testing: Various tests improve

Signed-off-by: Oriol Brufau <[email protected]>
shubhamg13 pushed a commit to shubhamg13/servo that referenced this pull request Mar 2, 2026
@Loirooriol @shubhamg13
build(deps): bump Stylo to "Make custom properties animatable" (servo…
aed601b 
…#42858)

Bumps Stylo to servo/stylo#316

Testing: Various tests improve

Signed-off-by: Oriol Brufau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yezhizhen yezhizhen yezhizhen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow animations of custom properties

2 participants

@Loirooriol @yezhizhen