Merged
Conversation
mrobinson
approved these changes
Jan 28, 2026
Signed-off-by: Luke Warlow <[email protected]>
lukewarlow
force-pushed
the
modal-parse
branch
from
8db0743 to
e569683
Compare
Collaborator
|
Please don't land Stylo PRs if the companion Servo PR is not ready. This is now affecting other people who want to land Stylo changes. |
Member
Author
|
Apologies, it was ready but got merge conflicted by other merges. |
Member
I understood that in this case the Servo PR was ready, so we followed our strategy but still had issues. It's hard to avoid this always. |
yezhizhen
added a commit
to yezhizhen/stylo
that referenced
this pull request
Jan 31, 2026
This reverts commit 9493c5f.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2026
This reverts commit 9493c5f as hoping to land #293 first. FYI @lukewarlow
Member
|
@lukewarlow This one was reverted, but do you mind posting it again so that we can try to land it? Thanks! |
Loirooriol
pushed a commit
that referenced
this pull request
Feb 5, 2026
Servo PR: servo/servo#42201 Signed-off-by: Luke Warlow <[email protected]>
Loirooriol
pushed a commit
that referenced
this pull request
Feb 5, 2026
This reverts commit 9493c5f as hoping to land #293 first. FYI @lukewarlow
Loirooriol
pushed a commit
that referenced
this pull request
Feb 5, 2026
Servo PR: servo/servo#42201 Signed-off-by: Luke Warlow <[email protected]>
Loirooriol
pushed a commit
that referenced
this pull request
Feb 5, 2026
This reverts commit 9493c5f as hoping to land #293 first. FYI @lukewarlow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Servo PR: servo/servo#42201