Enable layout.css.properties-and-values.enabled#293
Merged
Loirooriol merged 1 commit intoservo:mainfrom Jan 31, 2026
Merged
Conversation
nicoburns
approved these changes
Jan 25, 2026
Loirooriol
requested changes
Jan 25, 2026
Collaborator
Loirooriol
left a comment
Loirooriol
left a comment
There was a problem hiding this comment.
This doesn't address servo/servo#41417 (comment)
Member
Author
But can't we leave it as a follow up? It is set as non-animatable in the fixup commits anyway, so shouldn't cause crash. |
Member
Author
There is no crash thanks to the fixup you proposed. So it is good for now? |
Collaborator
|
As a rule of thumb , features shouldn't be enabled until they are properly implemented, because otherwise it defeats feature checking and it can end up breaking more than it fixes. But we don't supports Still, thinking long-term I would like to do these king of things with experimental flags, which I don't think is currently possible for Stylo static prefs. |
Loirooriol
approved these changes
Jan 26, 2026
mrobinson
approved these changes
Jan 28, 2026
yezhizhen
force-pushed
the
test-property
branch
4 times, most recently
from
b3455e6 to
148aefe
Compare
Member
Author
|
Force pushing now, as rn the branch is based on #298. This is to confirm servo/servo#42136 (comment). |
yezhizhen
force-pushed
the
test-property
branch
from
148aefe to
a1a9533
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2026
This reverts commit 9493c5f as hoping to land #293 first. FYI @lukewarlow
Signed-off-by: Euclid Ye <[email protected]>
yezhizhen
force-pushed
the
test-property
branch
from
a1a9533 to
c1e2871
Compare
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Jan 31, 2026
…able (#42136) Many websites use Tailwind CSS script which utilizes registered custom properties. This PR makes such websites look as expected, such as #42129. Before: <img width="485" height="120" alt="image" src="https://github.com/user-attachments/assets/428000b1-eed1-4f10-bbf8-eca9e7b630f5" /> After: <img width="487" height="82" alt="image" src="https://github.com/user-attachments/assets/ab016cbf-9c00-4bd8-adc8-be28f13e42e5" /> Testing: Updated existing WPT results. Fixes: #42129 Fixes: #41417 Stylo Companion: servo/stylo#293 --------- Signed-off-by: Euclid Ye <[email protected]>
Loirooriol
pushed a commit
that referenced
this pull request
Feb 5, 2026
This reverts commit 9493c5f as hoping to land #293 first. FYI @lukewarlow
Loirooriol
pushed a commit
that referenced
this pull request
Feb 5, 2026
This will add support for `@property` rules. Servo Companion: servo/servo#42136 Note that registered properties don't animate correctly: #38 Signed-off-by: Euclid Ye <[email protected]>
Loirooriol
pushed a commit
that referenced
this pull request
Feb 5, 2026
This reverts commit 9493c5f as hoping to land #293 first. FYI @lukewarlow
Loirooriol
pushed a commit
that referenced
this pull request
Feb 5, 2026
This will add support for `@property` rules. Servo Companion: servo/servo#42136 Note that registered properties don't animate correctly: #38 Signed-off-by: Euclid Ye <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will add support for
@propertyrules.Servo Companion: servo/servo#42136
Note that registered properties don't animate correctly: #38