Add stacking context damage when outline-width becomes non-zero#274
Merged
Loirooriol merged 1 commit intoservo:mainfrom Nov 27, 2025
Merged
Add stacking context damage when outline-width becomes non-zero#274Loirooriol merged 1 commit intoservo:mainfrom
Loirooriol merged 1 commit intoservo:mainfrom
Conversation
As an optimization, we skip outlines in the stacking context if they have a width of zero. This means that when it becomes non-zero, we need stacking context damage. Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Oriol Brufau <[email protected]>
mrobinson
approved these changes
Nov 27, 2025
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Nov 27, 2025
#40916) Bumps Stylo to servo/stylo#274 Testing: Adding new test Signed-off-by: Oriol Brufau <[email protected]> Co-authored-by: Martin Robinson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an optimization, we skip outlines in the stacking context if they have a width of zero. This means that when it becomes non-zero, we need stacking context damage.