Conversation
…oburns,oriol,#style I want to update the UrlExtraData of the stylesheet contents when cloning for uniqueness. This removes an API that servo uses but that's easily replaceable, see: servo/servo#40024 Differential Revision: https://phabricator.services.mozilla.com/D269200
…r=#style,Oriol,nicoburns I want the iter_mut() methods to fix servo/servo#40024. But we can simplify this a little bit nowadays to avoid duplicating a lot of code. Differential Revision: https://phabricator.services.mozilla.com/D269226
Loirooriol
reviewed
Oct 21, 2025
style/stylesheets/rule_list.rs
Outdated
| pub fn parse_rule_for_insert( | ||
| &self, | ||
| lock: &SharedRwLock, | ||
| guard: &SharedRwLockReadGuard, |
… the StylesheetContents without needing a whole new stylesheet. r=oriol,nicoburns,#style Put the Arc<StylesheetContents> under a Locked<T> so that Servo can replace it. Differential Revision: https://phabricator.services.mozilla.com/D269382
Loirooriol
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For servo/servo#40024