Enable font-synthesis-weight support for servo#244
Merged
jdm merged 5 commits intoservo:mainfrom Oct 1, 2025
Merged
Conversation
Signed-off-by: minghuaw <[email protected]>
Signed-off-by: minghuaw <[email protected]>
Signed-off-by: minghuaw <[email protected]>
Signed-off-by: minghuaw <[email protected]>
Collaborator
|
Can you open a companion PR in Servo, to run tests? |
Contributor
Author
|
I've opened a draft PR in servo servo/servo#39519 |
jdm
approved these changes
Sep 30, 2025
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Oct 1, 2025
This is an initial attempt at implementing synthetic bold face for font families that lack actual bold faces. The overall approach borrowed implementations from Chromium and FireFox. WPT expectations will be updated after servo/stylo#244 lands Testing: There are existing WPT testcases for font synthesis (`wpt/css/css-fonts/font-synthesis-*`) Depends on: servo/stylo#244 --------- Signed-off-by: Minghua Wu <[email protected]> Signed-off-by: minghuaw <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Oct 1, 2025
This is an initial attempt at implementing synthetic bold face for font families that lack actual bold faces. The overall approach borrowed implementations from Chromium and FireFox. WPT expectations will be updated after servo/stylo#244 lands Testing: There are existing WPT testcases for font synthesis (`wpt/css/css-fonts/font-synthesis-*`) Depends on: servo/stylo#244 --------- Signed-off-by: Minghua Wu <[email protected]> Signed-off-by: minghuaw <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Oct 1, 2025
This is an initial attempt at implementing synthetic bold face for font families that lack actual bold faces. The overall approach borrowed implementations from Chromium and FireFox. WPT expectations will be updated after servo/stylo#244 lands Testing: There are existing WPT testcases for font synthesis (`wpt/css/css-fonts/font-synthesis-*`) Depends on: servo/stylo#244 --------- Signed-off-by: Minghua Wu <[email protected]> Signed-off-by: minghuaw <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Oct 1, 2025
This is an initial attempt at implementing synthetic bold face for font families that lack actual bold faces. The overall approach borrowed implementations from Chromium and FireFox. WPT expectations will be updated after servo/stylo#244 lands Testing: There are existing WPT testcases for font synthesis (`wpt/css/css-fonts/font-synthesis-*`) Depends on: servo/stylo#244 --------- Signed-off-by: Minghua Wu <[email protected]> Signed-off-by: minghuaw <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified mako templates to enable
font-synthesis-weightsupport for servo. Added necessary derive macros forFontSynthesis