Define implemented pseudo-element for input type=text#217
Merged
nicoburns merged 1 commit intoservo:mainfrom Jul 22, 2025
Merged
Define implemented pseudo-element for input type=text#217nicoburns merged 1 commit intoservo:mainfrom
type=text#217nicoburns merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: stevennovaryo <[email protected]>
stevennovaryo
changed the title
type=texttype=text
Contributor
|
The Servo-side code review is finished. Can anyone merge this first? |
xiaochengh
approved these changes
Jul 22, 2025
nicoburns
approved these changes
Jul 22, 2025
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Jul 23, 2025
) Depends on #37427. In addition to the changes introduced by #37065, there are several performance improvements and nits as follows: - Use the internal pseudo element for style matching, this will reduce the performance regression by ~66%. - Manual construction of the `Text` node inside a text container. This is followed by the modification of the inner `Text` node instead of using `SetTextContent` which is more expensive. - Use `implemented_pseudo_element` instead of `text_control_inner_editor` `NodeFlag` to handle the special cases that these elements should follow, specifically the: - focus delegation workaround; - selections; and - line height resolving. - More documentation. Servo's side of: servo/stylo#217 Testing: No new unexpected WPT failure, except for the one introduced by #37065. Fixes: #36307 #37205 --------- Signed-off-by: stevennovaryo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
::placeholder,::-servo-text-control-inner-editor, and::-servo-text-control-inner-container. The implemented pseudo elements that support style matching for Inputtype=textUA Shadow DOM. All of these pseudos will be defined as a lazy and accessible only in UA stylesheet (private).Contrary to
::placeholderstatus as a standardized pseudo element, it will be defined as a private pseudo for now due to the lack of property restriction and placeholder for<textarea>being not implemented.Stylo side of servo/servo#37483