Add ServoRestyleDamage::RECALCULATE_OVERFLOW#194
Merged
Loirooriol merged 1 commit intoservo:mainfrom May 30, 2025
Merged
Conversation
This restyle damage will be used for properties that affect overflow but not layout, like `transform`. The flag isn't currenlty used yet, that will happen in a follow-up. Signed-off-by: Oriol Brufau <[email protected]> Co-authored-by: Martin Robinson <[email protected]>
Loirooriol
force-pushed
the
recalculate-overflow
branch
from
6bcad12 to
c86296a
Compare
mrobinson
approved these changes
May 30, 2025
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
May 30, 2025
…37203) Instead of computing scrollable overflow while constructing the fragment tree, we will now do it later. In the future this will also allow to only recalculate the overflow without rebuilding the tree when transform properties change, but that's left for a follow-up. Stylo PR: servo/stylo#194 Testing: One test is now passing (more investigation is needed), but otherwise this isn't expected to have any effect. Signed-off-by: Oriol Brufau <[email protected]> Co-authored-by: Martin Robinson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restyle damage will be used for properties that affect overflow but not layout, like
transform.The flag isn't currently used yet, that will happen in a follow-up.
Servo PR: servo/servo#37203