API tweaks for Taffy calc() integration#104
Merged
nicoburns merged 2 commits intoservo:mainfrom Jan 7, 2025
Merged
Conversation
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
3 tasks
Loirooriol
approved these changes
Jan 6, 2025
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Nov 14, 2025
Depends on: - servo/stylo#104 - #34926 - #34927 - #34948 In addition to that a `resolve_calc_value` function has been added which resolves calc values during the layout process once a percentage resolution basis is available. ~~There is 1 newly failing test and 1 newly failing subtest here.~~ These issues have now been fixed. There are 8 new subtest failures in `css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html`. These are genuine failures, but are unrelated to the calc implementation. The calc implementation is just exposing a pre-existing bug around percentage resolution that also now correctly also applies to `calc()` values containing percentages. The fix for would best be done in a followup as it requires teaching Taffy about "compressible replaced elements". (update: I have this [implemented](#34948) but in the interest of keeping it to one feature per PR I have not included it here) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors. It doesn't like the git dependency on Taffy. - [x] There are tests for these changes OR --------- Signed-off-by: Nico Burns <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Nov 14, 2025
Depends on: - servo/stylo#104 - #34926 - #34927 - #34948 In addition to that a `resolve_calc_value` function has been added which resolves calc values during the layout process once a percentage resolution basis is available. ~~There is 1 newly failing test and 1 newly failing subtest here.~~ These issues have now been fixed. There are 8 new subtest failures in `css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html`. These are genuine failures, but are unrelated to the calc implementation. The calc implementation is just exposing a pre-existing bug around percentage resolution that also now correctly also applies to `calc()` values containing percentages. The fix for would best be done in a followup as it requires teaching Taffy about "compressible replaced elements". (update: I have this [implemented](#34948) but in the interest of keeping it to one feature per PR I have not included it here) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors. It doesn't like the git dependency on Taffy. - [x] There are tests for these changes OR --------- Signed-off-by: Nico Burns <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitted upstream as https://bugzilla.mozilla.org/show_bug.cgi?id=1939791, but don't want to wait for sync before posting Servo PR.
Changes made:
LengthPercentage::unpackand theUnpacktype it returns public. Used to access the address of the boxedCalcLengthPercentagevalue so that it can be passed into Taffy.OpaqueElement::from_non_null_ptr. This is used to avoid Undefined Behaviour when constructing anOpaqueElementfrom an index which is unlikely to be a valid memory address. Technically not related tocalc()but it's a small change, and I've bundled them when submitting upstream.This will help enable support for
calc()values for CSS Grid containers/items in Servo.