Skip to content

No more headless compositor. Just the normal one.#8641

Merged
bors-servo merged 2 commits intoservo:masterfrom
notriddle:no_headless
Mar 29, 2016
Merged

No more headless compositor. Just the normal one.#8641
bors-servo merged 2 commits intoservo:masterfrom
notriddle:no_headless

Conversation

@notriddle
Copy link
Copy Markdown
Contributor

@notriddle notriddle commented Nov 21, 2015

Fixes #8573

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 21, 2015
@highfive
Copy link
Copy Markdown

highfive commented Nov 21, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@jdm
Copy link
Copy Markdown
Member

jdm commented Nov 21, 2015

@bors-servo: try

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

⌛ Trying commit e4857ef with merge 2f1f282...

bors-servo pushed a commit that referenced this pull request Nov 21, 2015
Auto merge of #8641 - notriddle:no_headless, r=<try>
2f1f282 
No more headless compositor. Just the normal one.

Fixes #8573

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8641)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. S-tests-failed The changes caused existing tests to fail. labels Nov 21, 2015
@notriddle
Copy link
Copy Markdown
Contributor Author

notriddle commented Nov 21, 2015

... yeah, probably should have fixed the headless compilation mode. :-).

@bors-servo try

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

⌛ Trying commit fb68735 with merge 722dd91...

bors-servo pushed a commit that referenced this pull request Nov 21, 2015
Auto merge of #8641 - notriddle:no_headless, r=<try>
722dd91 
No more headless compositor. Just the normal one.

Fixes #8573

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8641)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

💔 Test failed - gonk

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. S-tests-failed The changes caused existing tests to fail. labels Nov 21, 2015
@notriddle
Copy link
Copy Markdown
Contributor Author

notriddle commented Nov 21, 2015

@bors-servo try

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

⌛ Trying commit 5dd0aa8 with merge 4ec3b6e...

bors-servo pushed a commit that referenced this pull request Nov 21, 2015
Auto merge of #8641 - notriddle:no_headless, r=<try>
4ec3b6e 
No more headless compositor. Just the normal one.

Fixes #8573

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8641)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

💔 Test failed - gonk

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. S-tests-failed The changes caused existing tests to fail. labels Nov 21, 2015
@notriddle
Copy link
Copy Markdown
Contributor Author

notriddle commented Nov 21, 2015

I'm tempted to set up a Gonk environment, but that seems like such a pain for a port I don't want to work on. And if I ever hit a Mac-specific bug (haven't yet, but thought I did once) I really don't want to buy a Mac...

@bors-servo try

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

⌛ Trying commit 0259544 with merge ffb27e3...

bors-servo pushed a commit that referenced this pull request Nov 21, 2015
Auto merge of #8641 - notriddle:no_headless, r=<try>
ffb27e3 
No more headless compositor. Just the normal one.

Fixes #8573

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8641)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. S-tests-failed The changes caused existing tests to fail. labels Nov 21, 2015
@notriddle
Copy link
Copy Markdown
Contributor Author

notriddle commented Mar 23, 2016

@jdm mac-rel-wpt didn't fail on it.

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 23, 2016

⌛ Testing commit 2d6163a with merge bf3248f...

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 23, 2016

💔 Test failed - linux-rel

@jdm
Copy link
Copy Markdown
Member

jdm commented Mar 23, 2016

I think this needs to wait for #10082, unfortunately, otherwise we'll need to disable #9723 because it will have such a high frequency of intermittent failures.

@asajeffrey
Copy link
Copy Markdown
Contributor

asajeffrey commented Mar 23, 2016

#10082 is currently waiting for a sensible testing story. We could accelerate it, since testing is more about dealing with pipeline panics than lookup failures.

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 24, 2016

☔ The latest upstream changes (presumably #10150) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm
Copy link
Copy Markdown
Member

jdm commented Mar 24, 2016

I would be ok disabling #9723 so this could merge.

@asajeffrey
Copy link
Copy Markdown
Contributor

asajeffrey commented Mar 24, 2016

Sounds sensible to me. #10082 should re-enable it.

@notriddle
No more headless compositor. Just the normal one.
c9cb483 
This changes headless operation to strictly be a runtime option, rather
than a compile-time one. Note that the old headless version still relied
on a display server to support WebGL, while it now requires one all the
time.

Fixes #8573
@notriddle
Disable template-contents-owner-test-002.html
a5a299e 
#9723
@notriddle
Copy link
Copy Markdown
Contributor Author

notriddle commented Mar 24, 2016

@bors-servo r=glennw

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 24, 2016

🔑 Insufficient privileges

@jdm
Copy link
Copy Markdown
Member

jdm commented Mar 24, 2016

@bors-servo: r=glennw

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 24, 2016

📌 Commit a5a299e has been approved by glennw

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 24, 2016

⌛ Testing commit a5a299e with merge 2e8443a...

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 24, 2016

💔 Test failed - linux-rel

@notriddle
Copy link
Copy Markdown
Contributor Author

notriddle commented Mar 24, 2016

@bors-servo retry

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 24, 2016

⚡ Previous build results for android, arm32, gonk, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor are reusable. Rebuilding only linux-rel...

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 24, 2016

💔 Test failed - linux-rel

@notriddle
Copy link
Copy Markdown
Contributor Author

notriddle commented Mar 24, 2016

These websocket tests aren't going to pass, are they?

@jdm
Copy link
Copy Markdown
Member

jdm commented Mar 28, 2016

@bors-servo: retry

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 28, 2016

⌛ Testing commit a5a299e with merge 5e4d901...

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 28, 2016

💔 Test failed - mac-rel-wpt

@notriddle
Copy link
Copy Markdown
Contributor Author

notriddle commented Mar 28, 2016

How 'bout we wait for #10240?

@notriddle
Copy link
Copy Markdown
Contributor Author

notriddle commented Mar 29, 2016

@bors-servo retry

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 29, 2016

⌛ Testing commit a5a299e with merge aac2da7...

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Mar 29, 2016

☀️ Test successful - android, arm32, gonk, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, status-appveyor

This was referenced Mar 29, 2016
Merged
Merged
@aneeshusa aneeshusa mentioned this pull request May 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@glennw glennw

Labels

S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.