Skip to content

Implement 'url!(..)' macro#8622

Merged
bors-servo merged 1 commit intoservo:masterfrom
frewsxcv:url-plugin
Nov 21, 2015
Merged

Implement 'url!(..)' macro#8622
bors-servo merged 1 commit intoservo:masterfrom
frewsxcv:url-plugin

Conversation

@frewsxcv
Copy link
Copy Markdown
Contributor

@frewsxcv frewsxcv commented Nov 20, 2015

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 20, 2015
@frewsxcv frewsxcv mentioned this pull request Nov 20, 2015
Closed
@SimonSapin
Copy link
Copy Markdown
Member

SimonSapin commented Nov 20, 2015

@bors-servo r+

Thanks!

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 20, 2015

📌 Commit bf97f8f has been approved by SimonSapin

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 20, 2015
@frewsxcv
Copy link
Copy Markdown
Contributor Author

frewsxcv commented Nov 20, 2015

@bors-servo r-

Tidy...

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 20, 2015
@frewsxcv
Copy link
Copy Markdown
Contributor Author

frewsxcv commented Nov 20, 2015

@bors-servo r=SimonSapin

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 20, 2015

📌 Commit e36bdb1 has been approved by SimonSapin

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 20, 2015
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 20, 2015

⌛ Testing commit e36bdb1 with merge 85308a5...

bors-servo pushed a commit that referenced this pull request Nov 20, 2015
Auto merge of #8622 - frewsxcv:url-plugin, r=SimonSapin
85308a5 
Implement 'url!(..)' macro

servo/rust-url#136

servo/rust-url#137

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8622)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 20, 2015

💔 Test failed - gonk

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 20, 2015
@jdm
Copy link
Copy Markdown
Member

jdm commented Nov 20, 2015

Lockfiles need updating.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 20, 2015
@frewsxcv
Copy link
Copy Markdown
Contributor Author

frewsxcv commented Nov 20, 2015

Lockfiles for cef and gonk have been added

@jdm
Copy link
Copy Markdown
Member

jdm commented Nov 20, 2015

@bors-servo: r=SimonSapin

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 20, 2015

📌 Commit 120c0d1 has been approved by SimonSapin

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 20, 2015
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

⌛ Testing commit 120c0d1 with merge 155a9d0...

bors-servo pushed a commit that referenced this pull request Nov 21, 2015
Auto merge of #8622 - frewsxcv:url-plugin, r=SimonSapin
155a9d0 
Implement 'url!(..)' macro

servo/rust-url#136

servo/rust-url#137

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8622)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

💔 Test failed - linux-dev

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 21, 2015
@eefriedman
Copy link
Copy Markdown
Contributor

eefriedman commented Nov 21, 2015 

/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:8:21: 8:23 error: relative URL without a base
/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:8                url!("").to_string());
                                                                                                 ^~
/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:8:16: 8:24 note: in this expansion of url! (defined in /home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/lib.rs)
/home/servo/buildbot/slave/linux-dev/build/tests/unit/plugin/url_plugin.rs:7:5: 8:38 note: in this expansion of assert_eq! (defined in <std macros>)

@frewsxcv
Copy link
Copy Markdown
Contributor Author

frewsxcv commented Nov 21, 2015

Ah yeah. I reverted that usage locally but apparently forgot to commit it. Without my computer right now so I'll have to fix it later.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 21, 2015
@frewsxcv
Copy link
Copy Markdown
Contributor Author

frewsxcv commented Nov 21, 2015

Removed it in the latest force push

@jdm
Copy link
Copy Markdown
Member

jdm commented Nov 21, 2015

@bors-servo: r=SimonSapin

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

📌 Commit f34da41 has been approved by SimonSapin

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 21, 2015
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

⌛ Testing commit f34da41 with merge ea690a2...

bors-servo pushed a commit that referenced this pull request Nov 21, 2015
Auto merge of #8622 - frewsxcv:url-plugin, r=SimonSapin
ea690a2 
Implement 'url!(..)' macro

servo/rust-url#136

servo/rust-url#137

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8622)
<!-- Reviewable:end -->
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Nov 21, 2015

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@bors-servo bors-servo merged commit f34da41 into servo:master Nov 21, 2015
@bors-servo bors-servo mentioned this pull request Nov 21, 2015
Closed
@frewsxcv frewsxcv deleted the url-plugin branch November 21, 2015 19:54
@SimonSapin SimonSapin mentioned this pull request Nov 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@frewsxcv @SimonSapin @bors-servo @jdm @eefriedman @highfive