compositing: Split Servo up into multiple sandboxed processes. by jdm · Pull Request #8599 · servo/servo

jdm · 2015-11-19T07:35:25Z

Multiprocess mode is enabled with the -M switch, and sandboxing is
enabled with the -S switch.

Rebase of #6884.

highfive · 2015-11-19T07:35:29Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify layout code, but no reftests are modified. Please consider adding a reftest!

jdm · 2015-11-19T07:35:39Z

@bors-servo: r=metajack

bors-servo · 2015-11-19T07:35:42Z

📌 Commit 8763475 has been approved by metajack

bors-servo · 2015-11-19T07:35:44Z

⌛ Testing commit 8763475 with merge 78658c0...

compositing: Split Servo up into multiple sandboxed processes. Multiprocess mode is enabled with the `-M` switch, and sandboxing is enabled with the `-S` switch. Rebase of #6884.

bors-servo · 2015-11-19T07:41:39Z

💔 Test failed - gonk

jdm · 2015-11-19T07:49:29Z

   Compiling gaol v0.0.1 (https://github.com/pcwalton/gaol#b309234f)
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/seccomp.rs:37:22: 37:36 error: unresolved name `AUDIT_ARCH_ARM` [E0425]
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/seccomp.rs:37 const ARCH_NR: u32 = AUDIT_ARCH_ARM;
                                                                                                                ^~~~~~~~~~~~~~
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/seccomp.rs:37:22: 37:36 help: run `rustc --explain E0425` to see a detailed explanation
error: aborting due to previous error

pcwalton · 2015-11-19T18:30:49Z

@jdm Pushed a gaol update to address that.

jdm · 2015-11-19T18:32:38Z

@bors-servo: r=metajack

bors-servo · 2015-11-19T18:32:38Z

📌 Commit 3327234 has been approved by metajack

bors-servo · 2015-11-19T18:49:56Z

⌛ Testing commit 3327234 with merge 24dbfdb...

compositing: Split Servo up into multiple sandboxed processes. Multiprocess mode is enabled with the `-M` switch, and sandboxing is enabled with the `-S` switch. Rebase of #6884.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8599)

bors-servo · 2015-11-19T18:52:23Z

💔 Test failed - gonk

jdm · 2015-11-19T19:01:16Z

/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:259:41: 259:71 error: mismatched types:
 expected `u32`,
    found `u64`
(expected u32,
    found u64) [E0308]
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:259                                         mem::size_of::<pid_t>() as u64) ==
                                                                                                                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:257:21: 260:77 note: in this expansion of assert! (defined in <std macros>)
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:259:41: 259:71 help: run `rustc --explain E0308` to see a detailed explanation
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:260:45: 260:75 error: mismatched types:
 expected `i32`,
    found `i64`
(expected i32,
    found i64) [E0308]
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:260                                             mem::size_of::<pid_t>() as i64);
                                                                                                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:257:21: 260:77 note: in this expansion of assert! (defined in <std macros>)
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:260:45: 260:75 help: run `rustc --explain E0308` to see a detailed explanation
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:273:28: 273:58 error: mismatched types:
 expected `u32`,
    found `u64`
(expected u32,
    found u64) [E0308]
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:273                            mem::size_of::<pid_t>() as u64) == mem::size_of::<pid_t>() as i64);
                                                                                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:271:9: 273:95 note: in this expansion of assert! (defined in <std macros>)
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:273:28: 273:58 help: run `rustc --explain E0308` to see a detailed explanation
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:273:63: 273:93 error: mismatched types:
 expected `i32`,
    found `i64`
(expected i32,
    found i64) [E0308]
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:273                            mem::size_of::<pid_t>() as u64) == mem::size_of::<pid_t>() as i64);
                                                                                                                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:271:9: 273:95 note: in this expansion of assert! (defined in <std macros>)
/home/servo/.cargo/git/checkouts/gaol-2f5ad236210c8e99/master/platform/linux/namespace.rs:273:63: 273:93 help: run `rustc --explain E0308` to see a detailed explanation
error: aborting due to 4 previous errors

jdm · 2015-11-19T19:46:41Z

I'm super confused about the build errors on non-linux platforms, since I can build it without issue on OS X (and the code being referenced in some errors does not appear to exist locally??)

jdm · 2015-11-19T19:47:44Z

Oh, it exists after rebasing. Delightful!

compositing: Split Servo up into multiple sandboxed processes. Multiprocess mode is enabled with the `-M` switch, and sandboxing is enabled with the `-S` switch. Rebase of #6884.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8599)

bors-servo · 2015-11-19T20:11:56Z

💔 Test failed - gonk

jdm · 2015-11-19T20:48:31Z

CRASH [expected OK] /dom/nodes/Document-createElement-namespace.html
  │ 
  │ thread 'Constellation' panicked at 'called `Result::unwrap()` on an `Err` value: ()', src/libcore/result.rs:736
  │ stack backtrace:
  │    1:     0x7f03dc3420a0 - <unknown>
  │    2:     0x7f03dc344de5 - <unknown>
  │    3:     0x7f03dc344831 - <unknown>
  │    4:     0x7f03dc32e4e3 - <unknown>
  │    5:     0x7f03dc32eb98 - <unknown>
  │    6:     0x7f03dc341771 - <unknown>
  │    7:     0x7f03dc37279f - <unknown>
  │    8:     0x7f03dad97447 - <unknown>
  │    9:     0x7f03dad28be6 - <unknown>
  │   10:     0x7f03dad11ea7 - <unknown>
  │   11:     0x7f03dad112a4 - <unknown>
  │   12:     0x7f03dc3415d8 - <unknown>
  │   13:     0x7f03dc33dbab - <unknown>
  │   14:     0x7f03dad11434 - <unknown>
  │   15:     0x7f03dc3438d3 - <unknown>
  │   16:     0x7f03d8359181 - <unknown>
  │   17:     0x7f03d8b7347c - <unknown>
  │   18:                0x0 - <unknown>
  │ thread 'Constellation' panicked at 'assertion failed: libc::close(self.fd) == 0', /home/servo/.cargo/git/checkouts/ipc-channel-d95a23d1f1577bfc/master/platform/linux/mod.rs:101
  │ stack backtrace:
  │    1:     0x7f03dc3420a0 - <unknown>
  │    2:     0x7f03dc344de5 - <unknown>
  │    3:     0x7f03dc344831 - <unknown>
  │    4:     0x7f03dc32e408 - <unknown>
  │    5:     0x7f03dc2eabff - <unknown>
  │    6:     0x7f03dc2e4235 - <unknown>
  │    7:     0x7f03dad4d62b - <unknown>
  │    8:     0x7f03dad975b6 - <unknown>
  │    9:     0x7f03dad28be6 - <unknown>
  │   10:     0x7f03dad11ea7 - <unknown>
  │   11:     0x7f03dad112a4 - <unknown>
  │   12:     0x7f03dc3415d8 - <unknown>
  │   13:     0x7f03dc33dbab - <unknown>
  │   14:     0x7f03dad11434 - <unknown>
  │   15:     0x7f03dc3438d3 - <unknown>
  │   16:     0x7f03d8359181 - <unknown>
  │   17:     0x7f03d8b7347c - <unknown>
  │   18:                0x0 - <unknown>
  └ thread panicked while panicking. aborting.

jdm · 2015-11-19T20:48:46Z

I'm used to seeing that first panic as a result of ipc::channel().unwrap().

Multiprocess mode is enabled with the `-M` switch, and sandboxing is enabled with the `-S` switch.

jdm · 2015-11-19T21:38:31Z

@bors-servo: try

bors-servo · 2015-11-19T21:38:33Z

⌛ Trying commit 1c13081 with merge 0630c08...

compositing: Split Servo up into multiple sandboxed processes. Multiprocess mode is enabled with the `-M` switch, and sandboxing is enabled with the `-S` switch. Rebase of #6884.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8599)

bors-servo · 2015-11-19T22:12:40Z

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

jdm · 2015-11-19T22:29:45Z

@bors-servo: r=metajack

bors-servo · 2015-11-19T22:29:47Z

📌 Commit 1c13081 has been approved by metajack

bors-servo · 2015-11-19T22:29:49Z

⌛ Testing commit 1c13081 with merge 8b39b9a...

compositing: Split Servo up into multiple sandboxed processes. Multiprocess mode is enabled with the `-M` switch, and sandboxing is enabled with the `-S` switch. Rebase of #6884.  [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8599)

bors-servo · 2015-11-19T23:04:02Z

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2015

highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2015

highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 19, 2015

jdm mentioned this pull request Nov 19, 2015

compositing: Split Servo up into multiple sandboxed processes. #6884

Closed

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 19, 2015

jdm force-pushed the e10s-redux branch from 8763475 to 3327234 Compare November 19, 2015 18:32

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 19, 2015

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 19, 2015

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 19, 2015

jdm force-pushed the e10s-redux branch from 3327234 to d3dd4f1 Compare November 19, 2015 19:57

highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 19, 2015

jdm added S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 19, 2015

compositing: Split Servo up into multiple sandboxed processes.

1c13081

Multiprocess mode is enabled with the `-M` switch, and sandboxing is enabled with the `-S` switch.

jdm force-pushed the e10s-redux branch from d3dd4f1 to 1c13081 Compare November 19, 2015 21:38

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 19, 2015

jdm removed the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Nov 19, 2015

highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2015

highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 19, 2015

bors-servo merged commit 1c13081 into servo:master Nov 19, 2015

This was referenced Nov 19, 2015

Support synchronous about:blank loads #8600

Closed

Split paint task messages from ScriptMsg #8598

Merged

Rust upgrade to rustc 1.6.0-nightly (5b4986fa5 2015-11-08) #8446

Merged

Ms2ger deleted the e10s-redux branch November 20, 2015 07:56

l0kod mentioned this pull request Nov 28, 2015

Create the Mac sandbox #268

Closed

Uh oh!

Conversation

jdm commented Nov 19, 2015

Uh oh!

highfive commented Nov 19, 2015

Uh oh!

jdm commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

jdm commented Nov 19, 2015

Uh oh!

pcwalton commented Nov 19, 2015

Uh oh!

jdm commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

jdm commented Nov 19, 2015

Uh oh!

jdm commented Nov 19, 2015

Uh oh!

jdm commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

jdm commented Nov 19, 2015

Uh oh!

jdm commented Nov 19, 2015

Uh oh!

jdm commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

jdm commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

bors-servo commented Nov 19, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants