Skip to content

Update euclid to 0.3#8241

Merged
bors-servo merged 2 commits intoservo:masterfrom
Manishearth:euclid_up
Oct 28, 2015
Merged

Update euclid to 0.3#8241
bors-servo merged 2 commits intoservo:masterfrom
Manishearth:euclid_up

Conversation

@Manishearth
Copy link
Copy Markdown
Member

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 28, 2015
@highfive
Copy link
Copy Markdown

warning Warning warning

  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!

@mbrubeck
Copy link
Copy Markdown
Contributor

@bors-servo r+

Note: The extra version of glutin was added because of servo/surfman#30 but is only used on Windows currently, and I don't think it'll cause any conflicts even there. Long-term, we should move Servo back to upstream glutin...

@bors-servo
Copy link
Copy Markdown
Contributor

📌 Commit 184b2ba has been approved by mbrubeck

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 28, 2015
@bors-servo
Copy link
Copy Markdown
Contributor

⌛ Testing commit 184b2ba with merge 0d699a2...

@metajack
Copy link
Copy Markdown
Collaborator

The other question I had was about cocoa on gonk.


Reviewed 24 of 24 files at r1, 16 of 16 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.


ports/gonk/Cargo.lock, line 215 [r1] (raw file):
Why does gonk depend on cocoa??


ports/gonk/Cargo.lock, line 674 [r1] (raw file):
This is a dupe dependency, here and elsewhere where it got added.


Comments from the review on Reviewable.io

@Manishearth
Copy link
Copy Markdown
Member Author

Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks pending.


ports/gonk/Cargo.lock, line 215 [r1] (raw file):
Because glutin does. Lockfiles aren't concerned with platform deps.


ports/gonk/Cargo.lock, line 674 [r1] (raw file):
This is because of rust-offscreen-rendering-context using the crates dep instead of our fork. As it should.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Copy Markdown
Contributor

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt

@emilio
Copy link
Copy Markdown
Member

emilio commented Oct 29, 2015

@mbrubeck It should be fixed in servo/surfman#33.
Sorry about that, I missed it on the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants