Skip to content

Initial support for line heights calculations.#502

Closed
jrfeenst wants to merge 4 commits intoservo:masterfrom
jrfeenst:line-height
Closed

Initial support for line heights calculations.#502
jrfeenst wants to merge 4 commits intoservo:masterfrom
jrfeenst:line-height

Conversation

@jrfeenst
Copy link
Copy Markdown
Contributor

@jrfeenst jrfeenst commented Jun 1, 2013

No description provided.

bors-servo and others added 4 commits May 29, 2013 10:45
See the explanation on the commit for more detail.

r? @metajack
…count but does align baselines based on the largest box.
…es are expecting pixels, not points like the docs say. The glyph advance is also scaled slightly to match what is show in Firefox.
@jdm
Copy link
Copy Markdown
Member

jdm commented Jun 7, 2013

@jrfeenst This seems to need a rebase.

@jrfeenst
Copy link
Copy Markdown
Contributor Author

jrfeenst commented Jun 8, 2013

I'm still working on the font size issues. It seems fine on mac now, but the font metrics are all wrong on Linux. I'll reopen this once I've fixed everything and rebased.

@jrfeenst jrfeenst closed this Jun 8, 2013
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
Local rectangle clipping for transformed primitives

Finishes servo#427 implementation, now the text is cut evenly and not aligned to tile borders.
Also refactored `build_bounding_rect()` as well as a bit of `assign_prims_to_screen_tiles()`.

![textrun-comparison3](https://cloud.githubusercontent.com/assets/107301/19860234/5ce0c85a-9f5e-11e6-82f2-d72f19e4641a.png)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/502)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
bors-servo added a commit that referenced this pull request Sep 27, 2020
…jang

Bump cbindgen from 0.14.2 to 0.14.6

Bumps [cbindgen](https://github.com/eqrion/cbindgen) from 0.14.2 to 0.14.6.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/eqrion/cbindgen/blob/master/CHANGES">cbindgen's changelog</a>.</em></p>
<blockquote>
<h2>0.14.6</h2>
<pre><code> * Fixed the builds with older versions of rustc.
</code></pre>
<h2>0.14.5</h2>
<pre><code> * Add support to specify line ending style ([#568](mozilla/cbindgen#568))
 * Add cbindgen:ptrs-as-arrays annotation to allow making function
   arguments C/C++ arrays.
</code></pre>
<h2>0.14.4</h2>
<pre><code> * Allow to override the mangling separator ([#502](mozilla/cbindgen#502))
<ul>
<li>
<p>cbindgen now handles better having ZSTs in template parameters, and
default template parameters (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/563">#563</a>).</p>
</li>
<li>
<p>Support for annotating nonnull pointers (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/558">#558</a>)</p>
</li>
<li>
<p>Fixed bitflags that overflow a signed integer (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/556">#556</a>)</p>
</li>
<li>
<p>Support for wildcard argument names (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/550">#550</a>)</p>
</li>
<li>
<p>Support for the never return type, with configurable annotation (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/549">#549</a>)</p>
</li>
<li>
<p>Properly reject arrays as function arguments (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/540">#540</a>)
</code></pre></p>
</li>
</ul>
<h2>0.14.3</h2>
<pre><code> * Introduce cbindgen:ignore comment annotation, to allow ignoring items or modules. ([#519](mozilla/cbindgen#519))
 * Support for casts in constant expressions. ([#526](mozilla/cbindgen#526))
 * Make a non-fatal error a warning message. ([#535](mozilla/cbindgen#535))
 * Add a --metadata option to the CLI, to allow passing pre-computed cargo metadata. ([#538](mozilla/cbindgen#538))
</code></pre>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/eqrion/cbindgen/commit/e4da7d39a6d1481420440b37dcfe85d7ea4527d5"><code>e4da7d3</code></a> v0.14.6</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/1e46e53ae22b1d85bc794911dd750543e374bad7"><code>1e46e53</code></a> v0.14.5</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/fe656442a562ad1c7c19706d7b068492ecf58230"><code>fe65644</code></a> Document ptrs-as-arrays annotation</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/07c3aed03e6a3b53a580f8c6cfc4c9ea446104bb"><code>07c3aed</code></a> Add ptrs-as-arrays tests</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/ee4638ab10f4a7dcf9a8abd3b5fc2e2463dfcde5"><code>ee4638a</code></a> Add an annotation to represent pointers as arrays</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/73ea04c2b0f8926ebb1491ab311e591721d5dbd2"><code>73ea04c</code></a> Add badge to README</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/6b56082be8403c9dfe237cf0d4274369b7a83cd9"><code>6b56082</code></a> Replace travis with Github Actions</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/fec6bdad8cd9a0d37d506a6033ae3ee21c4f6989"><code>fec6bda</code></a> Fix clippy warnings</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/3ca0e75ed906ae505740657647b08e04cd844f14"><code>3ca0e75</code></a> Add support for specifying line ending style (<a href="https://github-redirect.dependabot.com/eqrion/cbindgen/issues/568">#568</a>)</li>
<li><a href="https://github.com/eqrion/cbindgen/commit/83cdbd897f02eaecb090a3f216899dcc14b43959"><code>83cdbd8</code></a> Release v.0.14.4</li>
<li>Additional commits viewable in <a href="https://github.com/eqrion/cbindgen/compare/v0.14.2...v0.14.6">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=cbindgen&package-manager=cargo&previous-version=0.14.2&new-version=0.14.6)](https://dependabot.com/compatibility-score/?dependency-name=cbindgen&package-manager=cargo&previous-version=0.14.2&new-version=0.14.6)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
jdm pushed a commit to jdm/servo that referenced this pull request Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants