Skip to content

Refactor the script task to conform to current coding style#457

Merged
metajack merged 1 commit intoservo:masterfrom
pcwalton:refactor-script
May 16, 2013
Merged

Refactor the script task to conform to current coding style#457
metajack merged 1 commit intoservo:masterfrom
pcwalton:refactor-script

Conversation

@pcwalton
Copy link
Copy Markdown
Contributor

metajack added a commit that referenced this pull request May 16, 2013
Refactor the script task to conform to current coding style
@metajack metajack merged commit bb9882f into servo:master May 16, 2013
@pcwalton pcwalton deleted the refactor-script branch May 17, 2013 01:17
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
Vertex attributes cleanup

This is the preparation work for servo#457

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/610)
<!-- Reviewable:end -->
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
Instanced attributes

Closes servo#457

Performance-wise, I wasn't able to register a noticeable difference. Tested on https://github.com/servo/servo, full screen after the second page down, on `Mesa DRI Intel(R) HD Graphics 5500 (Broadwell GT2)` with resolution 2560x1440.

With the change, I got 4.5 ms mean GPU time in the first test, and 4.3 ms time in the second.
Without the change, I got 4.4 ms mean GPU time in the only test.

I suppose the difference is not visible since we are far from being VS-bound.

Note: this does not replace the optimization of having one large buffer in servo#456. Instanced attributes will benefit from it in the same way as UBOs.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/615)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants