devtools: Do not cache environment actor values#44765
Merged
Merged
Conversation
Member
Author
|
Depends on #44763 Now: Before: |
Currently Environment Objects are cached in `createEnvironmentActor`. That meant DevTools could keep showing an old value for a variable after execution had moved on to a different value. In this change, we keep caching the environment actor name, but make sure the current state is being reflected by refreshing the environment actor data each time. This keeps the actor id stable and is also closer to Firefox behavior. Signed-off-by: atbrakhi <[email protected]>
atbrakhi
changed the title
Member
Author
|
@eerii this should be ok to review now. We are caching actor names now and rebuild the values. we also update/register based on that. |
servo-highfive
added
the
S-awaiting-review
eerii
reviewed
May 7, 2026
Co-authored-by: eerii <[email protected]> Signed-off-by: atbrakhi <[email protected]>
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Environment Objects are cached in
createEnvironmentActor. That meant DevTools could keep showing an old value for a variable after execution had moved on to a different value.In this change, we keep caching the environment actor name, but make sure the current state is being reflected by refreshing the environment actor data each time.
This keeps actor id stable and is also closer to Firefox behavior.
Testing: Current tests are passing
Fixes: part of #36027