canvas: fix unrecognized offscreen webgl context#44159
Merged
Merged
Conversation
Signed-off-by: Niya Gupta <[email protected]>
Contributor
Author
|
Creating a draft PR with compiler errors because I need some help. @jdm I looked at the As part of getting the context step, I need to pass a It does not exist for the offscreen canvas. let window = self.global();
let canvas =
RootedHTMLCanvasElementOrOffscreenCanvas::OffscreenCanvas(DomRoot::from_ref(self));
let size = self.get_size();
let attrs = Self::get_gl_attributes(cx, options, can_gc)?;
let context = WebGLRenderingContext::new(
&window,
&canvas,
WebGLVersion::WebGL1,
size,
attrs,
can_gc,
)?;Do we need to create a And use that as a context instead? |
Member
|
Actually the code at and needs to be changed to accept a&GlobalScope, then
needs to be rewritten to downcast the global to a Window or WorkerGlobalScope. Then we'll need to add servo/components/script/dom/window.rs Lines 680 to 684 in 38f77f4 servo/components/script/dom/window.rs Lines 382 to 384 in 38f77f4 |
Member
|
I think you will need to add a webgl_chan member to , and then you can access it from WorkerGlobalScope::new. Then you can add a webgl_chan argument to and get it from the globals at the callsites by (again) downcasting them to Window or WorkerGlobalScope. |
Contributor
Author
|
@jdm While calling Expects a servo/components/script/dom/window.rs Lines 680 to 684 in 38f77f4 How should I go about returning |
Member
|
That's fun! I suggest adding a temporary method to Window to return the WebGLChan until #44193 is fixed. |
Signed-off-by: Niya Gupta <[email protected]>
Contributor
Author
|
Thanks for the help @jdm! That said, I still need to work on some stuff: In the servo/components/script/dom/canvas/2d/canvas_state.rs Lines 674 to 675 in d11fc3a Same for the servo/components/script/dom/canvas/2d/canvas_state.rs Lines 781 to 785 in d11fc3a I copied an unsafe method and implemented it on the I think this should be okay, although, I am not sure if there is a better way. Test Result Summary
Details |
jdm
reviewed
Apr 14, 2026
Member
|
Exciting! This is looking really good! |
Signed-off-by: Niya Gupta <[email protected]>
niyabits
force-pushed
the
canvas/fix-getcontext-webgl
branch
from
e240528 to
dc758c1
Compare
Signed-off-by: Niya Gupta <[email protected]>
Signed-off-by: Niya Gupta <[email protected]>
servo-highfive
added
the
S-awaiting-review
jdm
reviewed
Apr 14, 2026
Comment on lines
+227
to
+229
| self.global() | ||
| .downcast::<Window>() | ||
| .and_then(|window| { |
Member
There was a problem hiding this comment.
Aha, we can file a followup issue about updating WebGLRenderingContext::new to accept a &GlobalScope argument instead.
jdm
added
S-needs-code-changes
Signed-off-by: Niya Gupta <[email protected]>
servo-highfive
added
S-awaiting-review
|
🔨 Triggering try run (#24417719696) for Linux (WPT) |
|
Test results for linux-wpt from try job (#24417719696): Flaky unexpected result (34)
Stable unexpected results that are known to be intermittent (17)
Stable unexpected results (13)
|
|
|
Signed-off-by: Niya Gupta <[email protected]>
Contributor
Author
Member
|
Let's merge this as is :) |
jdm
approved these changes
Apr 14, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix unrecognized type error on
OffscreenCanvasTesting: existing WPT:
tests/wpt/webgl/tests/conformance/offscreencanvastests/wpt/webgl/tests/conformance2/offscreencanvasFixes: #43540