Stylo: Enable text align match parent servo#44073
Conversation
|
🔨 Triggering try run (#24202318107) for Linux (WPT) |
|
Test results for linux-wpt from try job (#24202318107): Flaky unexpected result (36)
Stable unexpected results that are known to be intermittent (15)
Stable unexpected results (4)
|
|
|
|
Firefox has this in the UA stylesheet: https://searchfox.org/firefox-main/rev/62b11cf9d978f8c6f8144156feebf42af5d71cf9/layout/style/res/html.css#610-613 li {
display: list-item;
text-align: match-parent;
} |
|
🔨 Triggering try run (#24212315910) for Linux (WPT) |
|
Test results for linux-wpt from try job (#24212315910): Flaky unexpected result (41)
Stable unexpected results that are known to be intermittent (21)
Stable unexpected results (2)
|
|
|
|
You are not supposed to edit the ini manually. You could have just used |
Removes the `#[cfg(feature = "gecko")]` gate on `TextAlign::MatchParent` in `style/values/specified/text.rs`, enabling `text-align: match-parent` for Servo. The computation logic (resolving `start`/`end` to physical directions based on parent writing mode) was already correct and needed no changes. Servo PR: servo/servo#44073 Signed-off-by: Kelechi Ebiri <[email protected]>
Signed-off-by: Kelechi Ebiri <[email protected]>
Signed-off-by: Kelechi Ebiri <[email protected]>
Signed-off-by: Kelechi Ebiri <[email protected]>
Signed-off-by: Kelechi Ebiri <[email protected]>
…tations Signed-off-by: Kelechi Ebiri <[email protected]>
Oh okay, thanks. |
f6653dd to
9f7fa26
Compare
Companion PR for servo/stylo#350
Testing: Various WPT improve
Fixes: #43575