wpt: Enable /infrastructure tests (#20889)#43879
Merged
Merged
Conversation
Added the top-level `/infrastructure` WPT directory to `include.ini`, which was previously excluded by the root `skip: true` default. - Skipped `[reftest]` as I was unsure whether the failures indicate a real bug in Servo's reftest engine - Skipped `[testdriver][bidi]` as BiDi WebDriver is not supported - Added metadata for known expected failures (service workers, shared workers, expected-fail harness tests, etc.) - Removed stale metadata for tests that now pass Signed-off-by: CynthiaOketch <[email protected]>
mrobinson
reviewed
Apr 2, 2026
Comment on lines
+201
to
+202
| [reftest] | ||
| skip: true |
Member
There was a problem hiding this comment.
I think it is fine to not skip reftest.
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback! Just to confirm, should I remove the [reftest] section entirely, or set it to skip: false?
Member
There was a problem hiding this comment.
I think you can remove it entirely, but maybe double check that the tests inside the directory actually run.
Contributor
Author
There was a problem hiding this comment.
Okay, let me look into the failing checks first.
|
🔨 Triggering try run (#23919652226) for Linux (WPT) |
|
Test results for linux-wpt from try job (#23919652226): Flaky unexpected result (37)
Stable unexpected results that are known to be intermittent (19)
Stable unexpected results (3)
|
|
|
Restored metadata that was incorrectly removed as stale. Signed-off-by: CynthiaOketch <[email protected]>
Removed the `[reftest]` skip and added metadata for known expected failures. Signed-off-by: CynthiaOketch <[email protected]>
c669966 to
e73a656
Compare
yezhizhen
approved these changes
Apr 3, 2026
Member
yezhizhen
left a comment
There was a problem hiding this comment.
Very nice. Thisbis kinda important as it covers testdriver infrastructure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the top-level
/infrastructureWPT directory toinclude.ini, which was previously excluded by the rootskip: truedefault.[reftest]as I was unsure whether the failures indicate a real bug in Servo's reftest engine[testdriver][bidi]as BiDi WebDriver is not supportedTesting:
Ran
./mach test-wpt infrastructure/before and after the change.Before: 114 ran as expected, 69 unexpected results.
After: 166 ran as expected. Remaining 15 unexpected results are
all in /infrastructure/reftest/ which is skipped in include.ini.
Fixes: #20889