script: Run the focusing steps when navigating to a fragment by mrobinson · Pull Request #43859 · servo/servo

mrobinson · 2026-04-02T07:32:16Z

When navigating to a fragment the specification says to run the focusing
steps. This is possible now that the focusing steps are properly
exposed. This change also adds support for the fallback option, which is
used when the focus target is not associated with a focuable area. In
this case the fallback is to focus the viewport.

Testing: This change adds a new WPT for this behavior, which was seemingly not tested before.

github-actions · 2026-04-02T07:32:48Z

🔨 Triggering try run (#23889415627) for Linux (WPT)

servo-wpt-sync · 2026-04-02T07:36:09Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#58939) with upstreamable changes.

servo-wpt-sync · 2026-04-02T07:46:18Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#58939).

github-actions · 2026-04-02T08:03:58Z

Test results for linux-wpt from try job (#23889415627):

Flaky unexpected result (22)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- PASS [expected TIMEOUT] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
CRASH [expected OK] /content-security-policy/meta/sandbox-iframe.html (#43478)
FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
FAIL [expected PASS] /css/css-ui/appearance-radio-001.html
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
CRASH [expected OK] /html/anonymous-iframe/local-storage-initial-empty-document.tentative.https.window.html
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
TIMEOUT /html/semantics/embedded-content/media-elements/preserves-pitch.html (#40352)
- PASS [expected TIMEOUT] subtest: Speed-ups should not change the pitch when preservesPitch=true
- PASS [expected NOTRUN] subtest: Slow-downs should not change the pitch when preservesPitch=true
- TIMEOUT [expected NOTRUN] subtest: Speed-ups should change the pitch when preservesPitch=false
```
Test timed out
```

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-link-click.html (#32664)

FAIL [expected PASS] subtest: Navigating iframe loading='lazy' before it is loaded: link click

uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?nav" but got "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src"

TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html
- TIMEOUT [expected PASS] subtest: Post-navigation state reset.
```
Test timed out
```
OK /mixed-content/tentative/autoupgrades/mixed-content-cors.https.sub.html (#41123)
- PASS [expected FAIL] subtest: Cross-Origin video should get upgraded even if CORS is set
OK /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html
- FAIL [expected PASS] subtest: touch two-finger pan on 'touch-action: pan-x pan-y'
```
assert_equals: expected 2 but got 0
```
TIMEOUT [expected OK] /preload/modulepreload-sri-importmap.html (#43354)
- TIMEOUT [expected PASS] subtest: Script should not be loaded if modulepreload's integrity is invalid
```
Test timed out
```
OK /webdriver/tests/classic/element_click/center_point.py
- FAIL [expected PASS] subtest: test_entirely_in_view
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/element_click/file_upload.py
- FAIL [expected PASS] subtest: test_file_upload_state
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/execute_async_script/collections.py
- FAIL [expected PASS] subtest: test_arguments
```
AssertionError: no such window (404): No such window
```
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

Stable unexpected results that are known to be intermittent (18)

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /beacon/beacon-basic.https.window.html (#41723)
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = blob
```
assert_false: expected false got true
```
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted math (drawing text in a canvas)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
```
assert_equals: quoted generic(khmer-mul) matches  @font-face rule expected 125 but got 40
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-sans-serif (drawing text in a canvas)
OK /dom/nodes/moveBefore/iframe-document-preserve.window.html (#43152)
- PASS [expected FAIL] subtest: moveBefore(): cross-origin iframe is preserved: remove self
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
OK /fetch/metadata/window-open.https.sub.html (#40339)
- FAIL [expected PASS] subtest: Cross-site window, forced, reloaded
```
The operation is insecure.
```
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

CRASH [expected TIMEOUT] /html/browsers/history/the-location-interface/location_replace_session_history.html (#41896)
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- PASS [expected TIMEOUT] subtest: Non-HTMLElement should not support autofocus
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;
```
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
Test timed out
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- FAIL [expected PASS] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 0
```
OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)
OK /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
OK /trusted-types/trusted-types-reporting.html (#43737)
- PASS [expected FAIL] subtest: Trusted Type violation report: sample for custom element assignment

github-actions · 2026-04-02T08:04:07Z

✨ Try run (#23889415627) succeeded.

When navigating to a fragment the specification says to run the focusing steps. This is possible now that the focusing steps are properly exposed. This change also adds support for the fallback option, which is used when the focus target is not associated with a focuable area. In this case the fallback is to focus the viewport. Signed-off-by: Martin Robinson <[email protected]>

servo-wpt-sync · 2026-04-02T09:27:53Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#58939).

mrobinson requested a review from gterzian as a code owner April 2, 2026 07:32

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 2, 2026

mrobinson added the T-linux-wpt Do a try run of the WPT label Apr 2, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Apr 2, 2026

servo-wpt-sync mentioned this pull request Apr 2, 2026

script: Run the focusing steps when navigating to a fragment web-platform-tests/wpt#58939

Merged

mrobinson force-pushed the focus-target-when-navigating-to-a-fragment branch from 49e49e6 to 4da1bd2 Compare April 2, 2026 07:42

TimvdLippe approved these changes Apr 2, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 2, 2026

TimvdLippe added this pull request to the merge queue Apr 2, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 2, 2026

github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 2, 2026

servo-highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 2, 2026

mrobinson force-pushed the focus-target-when-navigating-to-a-fragment branch from 4da1bd2 to aa6ade5 Compare April 2, 2026 09:23

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-rebase There are merge conflict errors. labels Apr 2, 2026

mrobinson enabled auto-merge April 2, 2026 09:23

mrobinson added this pull request to the merge queue Apr 2, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 2, 2026

Merged via the queue into servo:main with commit 5b743ef Apr 2, 2026
33 checks passed

mrobinson deleted the focus-target-when-navigating-to-a-fragment branch April 2, 2026 10:14

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: Run the focusing steps when navigating to a fragment#43859

script: Run the focusing steps when navigating to a fragment#43859
mrobinson merged 1 commit into
servo:mainfrom
mrobinson:focus-target-when-navigating-to-a-fragment

mrobinson commented Apr 2, 2026

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

servo-wpt-sync commented Apr 2, 2026

Uh oh!

servo-wpt-sync commented Apr 2, 2026

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

servo-wpt-sync commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mrobinson commented Apr 2, 2026

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

servo-wpt-sync commented Apr 2, 2026

Uh oh!

servo-wpt-sync commented Apr 2, 2026

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

github-actions Bot commented Apr 2, 2026

Uh oh!

servo-wpt-sync commented Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants