Skip to content

devtools: Update outdated TODO#43851

Merged
mrobinson merged 2 commits into
servo:mainfrom
yezhizhen:todo-actor
Apr 2, 2026
Merged

devtools: Update outdated TODO#43851
mrobinson merged 2 commits into
servo:mainfrom
yezhizhen:todo-actor

Conversation

@yezhizhen
Copy link
Copy Markdown
Member

These were here 10 years ago.

  1. All Actor names are already immutable:
  • All actor implementations store a name: String field set at construction and never mutate it.
  • The name is only used as key by ActorRegistry to look up
  1. There is no register_later

Signed-off-by: Euclid Ye <[email protected]>
.
Signed-off-by: Euclid Ye <[email protected]>
@yezhizhen yezhizhen requested review from atbrakhi and eerii as code owners April 2, 2026 02:38
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 2, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 2, 2026
@mrobinson mrobinson added this pull request to the merge queue Apr 2, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 2, 2026
Merged via the queue into servo:main with commit beed346 Apr 2, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 2, 2026
@yezhizhen yezhizhen deleted the todo-actor branch April 2, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants