devtools: Rename NodeActor variables in walker.rs#43847
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
Signed-off-by: Eli Bowman <[email protected]>
treetmitterglad
force-pushed
the
devtools-device-actor-rename
branch
from
d5092ea to
e2c4ace
Compare
33 tasks
Collaborator
|
🛠 These changes could not be applied onto the latest upstream WPT. Servo's copy of the Web Platform Tests may be out of sync. |
eerii
changed the title
NodeActor variables in walker.rs
eerii
approved these changes
Apr 1, 2026
Member
eerii
left a comment
eerii
left a comment
There was a problem hiding this comment.
Thanks! Just for future reference, the update branch button in GitHub PRs makes the WPT bot fail and leave messages like that. So it's better if you can avoid it :)
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize variable naming in
WalkerActor(walker.rs), renamingnode→node_nameinfind_childto follow the{}_nameconvention.Testing:
./mach test-devtools, all 60 tests pass.Fixes: Part of #43606