Skip to content

devtools: rename LongStringActor name variables#43838

Merged
eerii merged 2 commits into
servo:mainfrom
niyabits:devtools/rename-LongStringActor-variable-names
Apr 1, 2026
Merged

devtools: rename LongStringActor name variables#43838
eerii merged 2 commits into
servo:mainfrom
niyabits:devtools/rename-LongStringActor-variable-names

Conversation

@niyabits
Copy link
Copy Markdown
Contributor

@niyabits niyabits commented Apr 1, 2026

Changes name to long_string_name
long_string to long_string_actor

Testing: Tested locally with mach test-devtools

Fixes: A part of #43606

@niyabits niyabits requested review from atbrakhi and eerii as code owners April 1, 2026 14:22
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 1, 2026
Copy link
Copy Markdown
Member

@eerii eerii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Would you mind also changing the new method to register like showed in #43800? That way we can finish LongStringActor for both issues :)

@niyabits
Copy link
Copy Markdown
Contributor Author

niyabits commented Apr 1, 2026

@eerii I have pushed changes that refactors new method to register method as well c:

Copy link
Copy Markdown
Member

@eerii eerii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you so much :)

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 1, 2026
@eerii eerii enabled auto-merge April 1, 2026 16:36
@eerii eerii added this pull request to the merge queue Apr 1, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 1, 2026
Merged via the queue into servo:main with commit 305276c Apr 1, 2026
30 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants