script: Implement PerformanceMeasureOptions#43753
Conversation
Signed-off-by: Simon Wülker <[email protected]>
|
🔨 Triggering try run (#23720375258) for Linux (WPT) |
|
Test results for linux-wpt from try job (#23720375258): Flaky unexpected result (27)
Stable unexpected results that are known to be intermittent (23)
Stable unexpected results (16)
|
|
|
|
🔨 Triggering try run (#23736835790) for Linux (WPT) |
Signed-off-by: Simon Wülker <[email protected]>
|
Test results for linux-wpt from try job (#23736835790): Flaky unexpected result (44)
Stable unexpected results that are known to be intermittent (21)
Stable unexpected results (15)
|
|
|
Signed-off-by: Simon Wülker <[email protected]>
8db883f to
5229b10
Compare
| @@ -0,0 +1,3 @@ | |||
| [mark-measure-feature-detection.html] | |||
| [Test PerformanceMeasure existence and feature detection] | |||
| expected: FAIL | |||
There was a problem hiding this comment.
This test tests unspecified behaviour as far as I can tell. We should probably pass it at some point but doing it correctly likely needs some investigation.
| [clearMeasures.html] | ||
| expected: ERROR |
There was a problem hiding this comment.
These error results appear because we don't implement step 1 of https://w3c.github.io/user-timing/#convert-a-mark-to-a-timestamp. We didn't implement it before either, but returned a nonsense value instead of throwing.
This reverts commit 1550163.
…(wpt)
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}]}
| fn can_add_resource_timing_entry(&self) -> bool { | ||
| // Step 1. If resource timing buffer current size is smaller than resource timing buffer size limit, return true. | ||
| // Step 2. Return false. | ||
| // TODO: Changing this to "<" (as per spec) does not result in passing tests, needs investigation |
There was a problem hiding this comment.
I verified this. It is stable now. We can remove this.
Is it fine, if I remove this TODO?
There was a problem hiding this comment.
If there are tests that pass as a result of that change, sure.
The relevant changes are in
Performance::Measure, the rest are comments I added.Testing: New tests start to pass