Skip to content

config: add a preference to allow fetching modulepreload descendants#43353

Merged
jdm merged 2 commits intoservo:mainfrom
Gae24:modulepreload-pref
Mar 20, 2026
Merged

config: add a preference to allow fetching modulepreload descendants#43353
jdm merged 2 commits intoservo:mainfrom
Gae24:modulepreload-pref

Conversation

@Gae24
Copy link
Copy Markdown
Contributor

@Gae24 Gae24 commented Mar 17, 2026

As suggested here, adds a preference to enable fetching modulepreload descendants, turned off by default.

Testing: A successful build is enough.

@Gae24 Gae24 requested a review from gterzian as a code owner March 17, 2026 12:18
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 17, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 18, 2026
@jdm jdm added this pull request to the merge queue Mar 18, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 18, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. S-tests-failed The changes caused existing tests to fail. labels Mar 18, 2026
@jdm jdm added S-needs-rebase There are merge conflict errors. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 20, 2026
@Gae24 Gae24 force-pushed the modulepreload-pref branch from c7d6b57 to eff26c5 Compare March 20, 2026 08:32
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-rebase There are merge conflict errors. labels Mar 20, 2026
@Gae24 Gae24 force-pushed the modulepreload-pref branch from eff26c5 to c9f48a5 Compare March 20, 2026 10:11
@jdm jdm added this pull request to the merge queue Mar 20, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 20, 2026
Merged via the queue into servo:main with commit 74ac696 Mar 20, 2026
30 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 20, 2026
niyabits pushed a commit to niyabits/servo that referenced this pull request Mar 21, 2026
…ervo#43353)

As suggested
[here](servo#42964 (comment)),
adds a preference to enable fetching modulepreload descendants, turned
off by default.

Testing: A successful build is enough.

---------

Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Niya Gupta <[email protected]>
@Gae24 Gae24 deleted the modulepreload-pref branch March 24, 2026 16:20
Gae24 added a commit to Gae24/servo that referenced this pull request Mar 26, 2026
…ervo#43353)

As suggested
[here](servo#42964 (comment)),
adds a preference to enable fetching modulepreload descendants, turned
off by default.

Testing: A successful build is enough.

---------

Signed-off-by: Gae24 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants