Skip to content

webdriver: Always wait for mousemove/wheel in a blocking manner#43262

Merged
yezhizhen merged 2 commits intoservo:mainfrom
yezhizhen:always-block
Mar 14, 2026
Merged

webdriver: Always wait for mousemove/wheel in a blocking manner#43262
yezhizhen merged 2 commits intoservo:mainfrom
yezhizhen:always-block

Conversation

@yezhizhen
Copy link
Copy Markdown
Member

This is now possible since #43202. We remove the workaround introduced long ago.

Testing: Before #43202, this would deadlock in many tests, and is therefore covered by existing tests.
Try

.
Signed-off-by: Euclid Ye <[email protected]>
@yezhizhen yezhizhen requested a review from xiaochengh March 14, 2026 05:48
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 14, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 14, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Mar 14, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 14, 2026
@yezhizhen yezhizhen removed this pull request from the merge queue due to a manual request Mar 14, 2026
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 14, 2026
Signed-off-by: Euclid Ye <[email protected]>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 14, 2026
@yezhizhen yezhizhen enabled auto-merge March 14, 2026 07:46
@yezhizhen yezhizhen added this pull request to the merge queue Mar 14, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 14, 2026
Merged via the queue into servo:main with commit 9cf33b7 Mar 14, 2026
33 checks passed
@yezhizhen yezhizhen deleted the always-block branch March 14, 2026 08:41
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 14, 2026
github-merge-queue bot pushed a commit that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants