script: Free memory earlier in hot path of input handling#43226
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Mar 13, 2026
Merged
script: Free memory earlier in hot path of input handling#43226TimvdLippe merged 1 commit intoservo:mainfrom
TimvdLippe merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <[email protected]>
servo-highfive
added
the
S-awaiting-review
Member
Author
|
It seems this is guaranteed to be better for all such occurrences:
Should we turn this into a "everywhere: ..." change? |
Contributor
Nice observation! And yes we should do that. Let's start with filing an issue to replace |
xiaochengh
approved these changes
Mar 13, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 1, 2026
…he temporary container if it is unused (#43826) Follow up of #43226 This also allows us to remove some `mut` declaration. Fix some unintended Chinese quotation mark. Testing: This is a micro-optimization which does not change visible behaviour. Signed-off-by: Euclid Ye <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hot path. This way we free the unused memory earlier.
Didn't realize the difference in #43202.
Testing: This is a memory optimization that does not change visible behaviour.