script: Replace the InputEventId of existing_constellation_wheel_event when coalescing wheel events#43138
Merged
yezhizhen merged 1 commit intoservo:mainfrom Mar 10, 2026
Merged
Conversation
Signed-off-by: Euclid Ye <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
changed the title
InputId of existing_constellation_wheel_event when coalescing eventsInputEventId of existing_constellation_wheel_event when coalescing events
yezhizhen
changed the title
InputEventId of existing_constellation_wheel_event when coalescing eventsInputEventId of existing_constellation_wheel_event when coalescing wheel events
mrobinson
approved these changes
Mar 10, 2026
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Seems fine as a workaround though we will need to address this for real as well.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, any testdriver tests with scroll duration
more than
16mscan be intermittent due to this.Fixes: #43136
Fixes: #43110
Testing: This fixes the issue where newly added test
in #43126 randomly TIMEOUT with very high probability:
https://github.com/servo/servo/actions/runs/22906496902