Conversation
servo-highfive
added
the
S-awaiting-review
|
The not-yet-merged fixes to dependencies required for Servo to actually run are servo/webrender#4880, servo/ipc-channel#444, servo/ipc-channel#445, and servo/ipc-channel#446. I have a personal branch which incorporates them, but I thought that I should submit what is upstreamable here as soon as possible. |
For #43116 Signed-off-by: sagudev <[email protected]>
Signed-off-by: Juhani Krekelä <juhani@krekelä.fi>
Signed-off-by: Juhani Krekelä <juhani@krekelä.fi>
This is what Firefox (see firefox/dom/base/Navigator.cpp) does.
WebKitGTK (see WebKit/Source/WebCore/platform/glib/UserAgentGlib.cpp)
similarly returns the same ("x11") on all non-macOS *nix platforms.
Signed-off-by: Juhani Krekelä <juhani@krekelä.fi>
This is enough to at least get it to build. Signed-off-by: Juhani Krekelä <juhani@krekelä.fi>
nortti0
force-pushed
the
freebsd-upstreaming
branch
from
628407c to
dd23928
Compare
|
Fixed the |
|
Also edited the original post of this thread to remove now-obsolete comments about mozjs and mozangle, since aiui that will become the commit message. |
|
In case it is unclear you need to have the signed-off on every commit you did. That is why DCO is complaining. Also it should probably be clear that the servo team does not have CI currently for testing freebsd changes. So this could break at any moment. But I still find it worth it to have in tree. |
I believe I have. The DCO check is buggy, and is barfing on my e-mail.
Yeah, I'm not expecting this to be upstream-supported; I'd just rather have the code in the repo and submit fixes for any possible breakage, rather than needing to maintain a larger downstream fork. What would be needed to set up a CI for FreeBSD? Aiui Github CI does not support it, so a built-in check would not be possible, but I wonder if I could run a system to provide best-effort information on whether something would break FreeBSD. |
|
I have set DCO to passing here due to the unfortunate bugs regarding non-ASCII character in email domain names |
|
Oh dear. That is unfortunate. I wonder if it would accept the domain name in punycode form: [email protected] |
|
Going to ping @delan for CI stuff. Perhaps she has an answer. |
based on actions/runner#385, there are some possible alternatives that can run commands in CI workflows using FreeBSD virtual machines under the hood. it’s not clear if the runner client just lacks official support for FreeBSD or if it’s actually broken on FreeBSD; if it’s the former, we may also be able to set up some self-hosted runners for FreeBSD someday if there’s enough demand for it :) |
|
Is there something I still need to do before the changes can be reviewed, or has this just ended up on the back burner? |
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
Just forgot about it. This looks fine!
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
7 participants
Add the minimum amount of FreeBSD-specific code to Servo, where no platform-neutral fallback exists.
Testing: I've succesfully built and run Servo on FreeBSD with these changes (and some fixes to dependencies). There's no functional change to any other targets. This pull request was created with Servo running on FreeBSD.
Fixes: #11625