Skip to content

script: Implement "getPublicKey" operations of ECDSA and ECDH#43106

Merged
yezhizhen merged 1 commit intoservo:mainfrom
kkoyung:get-public-key-ec
Mar 9, 2026
Merged

script: Implement "getPublicKey" operations of ECDSA and ECDH#43106
yezhizhen merged 1 commit intoservo:mainfrom
kkoyung:get-public-key-ec

Conversation

@kkoyung
Copy link
Copy Markdown
Member

@kkoyung kkoyung commented Mar 9, 2026

Implement "getPublicKey" operations of ECDSA and ECDH. The steps are implemented at the new submodule ec_common shared by ECDSA and ECDH.

To make the operations functioning, they are also registered at GetPublicKeyAlgorithm.

Specification: https://wicg.github.io/webcrypto-modern-algos/#SubtleCrypto-method-getPublicKey
Testing: Pass WPT tests that were expected to fail.
Fixes: Part of #43072

Implement "getPublicKey" operations of ECDSA and ECDH. The steps are
implemented at the new submodule `ec_common` shared by ECDSA and ECDH.

To make the operations functioning, they are also registered at
`GetPublicKeyAlgorithm`.

Specification: https://wicg.github.io/webcrypto-modern-algos/#SubtleCrypto-method-getPublicKey
Testing: Pass WPT tests that were expected to fail.
Fixes: Part of 43072

Signed-off-by: Kingsley Yung <[email protected]>
@kkoyung kkoyung requested a review from gterzian as a code owner March 9, 2026 09:27
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 9, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 9, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Mar 9, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 9, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 9, 2026
@Taym95 Taym95 added this pull request to the merge queue Mar 9, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 9, 2026
@yezhizhen yezhizhen removed this pull request from the merge queue due to a manual request Mar 9, 2026
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 9, 2026
@yezhizhen
Copy link
Copy Markdown
Member

This was failing Android build.

@yezhizhen yezhizhen added this pull request to the merge queue Mar 9, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 9, 2026
Merged via the queue into servo:main with commit c306038 Mar 9, 2026
42 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants