Skip to content

script: Coalesce wheel input events#43074

Merged
TimvdLippe merged 2 commits intoservo:mainfrom
webbeef:coalesce-wheel-events
Mar 7, 2026
Merged

script: Coalesce wheel input events#43074
TimvdLippe merged 2 commits intoservo:mainfrom
webbeef:coalesce-wheel-events

Conversation

@webbeef
Copy link
Copy Markdown
Contributor

@webbeef webbeef commented Mar 7, 2026

This follows the same principle used for mouse move events, but we have to update the event parameters since we receive the delta from the previous event.

Testing: Load https://docs.rs/iced-x86/1.21.0/iced_x86/code_asm/struct.CodeAssembler.html and try to scroll with the trackpad with and without this patch.
Fixes: Partial fix for #43062

@webbeef webbeef requested a review from gterzian as a code owner March 7, 2026 07:04
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 7, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 7, 2026
webbeef added 2 commits March 7, 2026 08:36
This follows the same principle used for mouse move events, but
we have to update the event parameters since we receive the
delta from the previous event.

Signed-off-by: webbeef <[email protected]>
Signed-off-by: webbeef <[email protected]>
@webbeef webbeef force-pushed the coalesce-wheel-events branch from c820ced to f4064f3 Compare March 7, 2026 16:38
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 7, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Mar 7, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 7, 2026
Merged via the queue into servo:main with commit cea658e Mar 7, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants