Skip to content

devtools: Get newest frame when resuming without a frameActorID#43040

Merged
jdm merged 1 commit into
servo:mainfrom
eerii:fix-get-frame-resume
Mar 6, 2026
Merged

devtools: Get newest frame when resuming without a frameActorID#43040
jdm merged 1 commit into
servo:mainfrom
eerii:fix-get-frame-resume

Conversation

@eerii
Copy link
Copy Markdown
Member

@eerii eerii commented Mar 5, 2026

Fixes resuming after stepping.

Testing: Ran existing DevTools test
Part of: #36027

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 5, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 5, 2026
@eerii eerii force-pushed the fix-get-frame-resume branch from 8307366 to 0e9d604 Compare March 5, 2026 17:24
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 5, 2026
@eerii eerii force-pushed the fix-get-frame-resume branch from 0e9d604 to ec7f9ac Compare March 5, 2026 17:26
@atbrakhi atbrakhi added this pull request to the merge queue Mar 6, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 6, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 6, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 6, 2026
@jdm jdm added this pull request to the merge queue Mar 6, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 6, 2026
Merged via the queue into servo:main with commit 836970d Mar 6, 2026
36 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 6, 2026
@eerii eerii deleted the fix-get-frame-resume branch March 6, 2026 09:02
offline-ant pushed a commit to offline-ant/havi that referenced this pull request Jun 4, 2026
…o#43040)

Fixes resuming after stepping.

Testing: Ran existing DevTools test
Part of: servo#36027

Signed-off-by: eri <[email protected]>
Co-authored-by: atbrakhi <[email protected]>
(cherry picked from commit 836970d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants