script: Implement miscellaneous commands related to delete#43028
Conversation
|
🔨 Triggering try run (#22708656394) for Linux (WPT) |
|
|
TimvdLippe
force-pushed
the
implement-miscellaneous-commands
branch
from
b99ca64 to
1ec238a
Compare
These two commands are intertwined with the delete command. By implementing them now, it becomes easier to triage actual implementation issues in the delete command. Part of servo#25005 Signed-off-by: Tim van der Lippe <[email protected]>
TimvdLippe
force-pushed
the
implement-miscellaneous-commands
branch
from
1ec238a to
e02cbcf
Compare
servo-highfive
added
the
S-awaiting-review
|
This is another case for |
|
Another day another 10 thousand passing subtests |
| command_id: &DOMString, | ||
| ) -> Option<DomRoot<Selection>> { | ||
| let selection = self.GetSelection(CanGc::from_cx(cx))?; | ||
| // > Among commands defined in this specification, those listed in Miscellaneous commands are always enabled, |
There was a problem hiding this comment.
This seems to not be true in the WPT tests. We see new failures for stylewithcss if the selection is input type="password", which is supposed to be supported, but not enabled.
There was a problem hiding this comment.
Unfortunately this is where the inconsistent implementation of this spec across browsers shows. The test failures match Chromium/Webkit: https://wpt.fyi/results/editing/other/exec-command-with-text-editor.tentative.html%3Ftype%3Dpassword?label=master&label=experimental&aligned Only Firefox passes these tests. Therefore, I am not actually sure we should match Firefox' behavior or not.
I would err to keep it as-is for now as the spec is written and revisit once we actually get closer to implementation of full support.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
These two commands are intertwined with the delete command. By implementing them now, it becomes easier to triage actual implementation issues in the delete command. Part of servo#25005 Signed-off-by: Tim van der Lippe <[email protected]> (cherry picked from commit 160e458)
4 participants
These two commands are intertwined with the delete command. By
implementing them now, it becomes easier to triage actual
implementation issues in the delete command.
Part of #25005