indexeddb: abort pending worker upgrade and delete new db on rollback by Taym95 · Pull Request #42998 · servo/servo

Taym95 · 2026-03-03T16:24:59Z

Abort pending upgrade requests when a worker closes, correctly roll back newlyy created databases by deleting backend state on old_version == 0.

Testing: IndexedDB/worker-termination-aborts-upgrade.window.js.ini test pass.
part of #40983

github-actions · 2026-03-03T16:25:54Z

🔨 Triggering try run (#22632427432) for Linux (WPT)

github-actions · 2026-03-03T17:06:00Z

Test results for linux-wpt from try job (#22632427432):

Flaky unexpected result (30)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error: Blob URL store error: InvalidFileID"
```

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

OK /_mozilla/mozilla/getBoundingClientRect.html (#39668)
- FAIL [expected PASS] subtest: getBoundingClientRect 1
```
assert_equals: expected 62 but got 60.35
```
OK /beacon/beacon-basic.https.window.html (#41723)
- PASS [expected FAIL] subtest: Payload size restriction should be accumulated: type = string
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = blob
```
assert_false: expected false got true
```
OK /cookies/partitioned-cookies/partitioned-cookies-samesite-attribute.https.html
- FAIL [expected PASS] subtest: In embedded cross-site contexts, partitioned cookies can only be set with explicit SameSite=None
```
assert_equals: expected 0 but got 3
```
TIMEOUT [expected OK] /credential-management/credentialscontainer-frame-basics.https.html (#39430)
- TIMEOUT [expected FAIL] subtest: navigator.credentials should be undefined in documents generated from data: URLs.
```
Test timed out
```
FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html (#41704)
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
CRASH [expected TIMEOUT] /html/anonymous-iframe/web-lock.tentative.https.window.html
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/semantics/embedded-content/media-elements/media_fragment_seek.html (#24114)
- PASS [expected FAIL] subtest: Video should seek to time specified in media fragment syntax
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.html (#33948)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Module fetching failed"
```
OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-import.html (#42419)
- FAIL [expected PASS] subtest: document.write in an imported module
```
assert_true: onload must be called expected true got false
```
TIMEOUT [expected OK] /mixed-content/gen/top.meta/unset/video-tag.https.html
- TIMEOUT [expected PASS] subtest: Mixed-Content: Expects allowed for video-tag to same-https origin and no-redirect redirection from https context.
```
Test timed out
```
PASS [expected FAIL] /png/apng/fcTL-dispose-none.html (#41817)
FAIL [expected PASS] /png/apng/fcTL-dispose-previous-first.html
OK /preload/link-header-preload-delay-onload.html (#39622)
- FAIL [expected PASS] subtest: Makes sure that Link headers preload resources and block window.onload after resource discovery
```
assert_true: expected true got false
```
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)
TIMEOUT [expected OK] /upgrade-insecure-requests/gen/iframe-blank-inherit.meta/upgrade/sharedworker-import-data.https.html
- TIMEOUT [expected FAIL] subtest: Upgrade-Insecure-Requests: Expects allowed for sharedworker-import-data to cross-http-downgrade origin and downgrade redirection from https context.
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Upgrade-Insecure-Requests: Expects allowed for sharedworker-import-data to cross-http-downgrade origin and no-redirect redirection from https context.
- NOTRUN [expected FAIL] subtest: Upgrade-Insecure-Requests: Expects allowed for sharedworker-import-data to cross-https origin and downgrade redirection from https context.
- NOTRUN [expected FAIL] subtest: Upgrade-Insecure-Requests: Expects allowed for sharedworker-import-data to same-http-downgrade origin and downgrade redirection from https context.
- NOTRUN [expected FAIL] subtest: Upgrade-Insecure-Requests: Expects allowed for sharedworker-import-data to same-http-downgrade origin and no-redirect redirection from https context.
- NOTRUN [expected FAIL] subtest: Upgrade-Insecure-Requests: Expects allowed for sharedworker-import-data to same-https origin and downgrade redirection from https context.
CRASH [expected OK] /webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/closed-audiocontext-construction.html

OK /webdriver/tests/classic/back/user_prompts.py

FAIL [expected PASS] subtest: test_accept[alert]

AssertionError: assert 'about:blank' == 'https://web-platform.test:8443/webdriver/tests/support/inline.py?doc=%3C%21doctype+html%3E%0A%3Cmeta+charset%3DUTF-8%3E%0A%3Cp+id%3D1%3E&amp;mime=text%2Fhtml&amp;charset=UTF-8'

OK /webdriver/tests/classic/get_current_url/file.py
- FAIL [expected PASS] subtest: test_get_current_url_file_protocol
```
AssertionError: no such window (404)
```
OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:

Stable unexpected results that are known to be intermittent (18)

FAIL [expected PASS] /_mozilla/css/img_size_a.html (#42908)
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- PASS [expected FAIL] subtest: sec-fetch-site - Same origin, no options - registration
OK [expected ERROR] /fetch/metadata/window-open.https.sub.html (#40339)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored
```
assert_equals: expected "?pass" but got "?fail"
```
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
OK /html/webappapis/user-prompts/print-during-unload.html (#35944)
- PASS [expected FAIL] subtest: print() during unload
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- TIMEOUT [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe

Stable unexpected results (1)

OK [expected TIMEOUT] /IndexedDB/idbfactory_open.any.worker.html
- PASS [expected FAIL] subtest: Calling open() with version argument 1.5 should not throw.
- PASS [expected TIMEOUT] subtest: Calling open() with version argument 9007199254740991 should not throw.
- PASS [expected TIMEOUT] subtest: Calling open() with version argument undefined should not throw.

github-actions · 2026-03-03T17:06:42Z

⚠️ Try run (#22632427432) failed!

github-actions · 2026-03-03T17:13:03Z

🔨 Triggering try run (#22634334160) for Linux (WPT)

github-actions · 2026-03-03T18:10:42Z

Test results for linux-wpt from try job (#22634334160):

Flaky unexpected result (29)

OK /FileAPI/url/url-with-fetch.any.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error: Blob URL store error: InvalidFileID"
```
OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error: Blob URL store error: InvalidFileID"
```
ERROR [expected OK] /_mozilla/mozilla/preserve_wrapper_callback.html
CRASH [expected OK] /_webgl/conformance2/wasm/readpixels-2gb-in-4gb-wasm-memory.html
FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- PASS [expected FAIL] subtest: sec-fetch-site - Same origin, no options - registration
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-default-feature-policy.https.sub.html (#41193)
- PASS [expected TIMEOUT] subtest: Default "autoplay" feature policy ["self"] allows same-origin iframes.
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html
- TIMEOUT [expected PASS] subtest: Post-navigation state reset.
```
Test timed out
```
OK /html/webappapis/user-prompts/print-during-unload.html (#35944)
- PASS [expected FAIL] subtest: print() during unload
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
FAIL [expected PASS] /png/apng/fcTL-dispose-previous-first.html
OK /preload/link-header-preload-delay-onload.html (#39622)
- FAIL [expected PASS] subtest: Makes sure that Link headers preload resources and block window.onload after resource discovery
```
assert_true: expected true got false
```
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- TIMEOUT [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
OK /visual-viewport/resize-event-order.html (#41981)
- PASS [expected FAIL] subtest: Popup: DOMWindow resize fired before VisualViewport.
OK /webdriver/tests/classic/element_send_keys/events.py
- FAIL [expected PASS] subtest: test_file_upload
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/execute_async_script/window.py
- FAIL [expected PASS] subtest: test_web_reference[frame]
```
AssertionError: no such window (404): No such window
```
OK /webdriver/tests/classic/find_elements/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/get_page_source/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/take_screenshot/iframe.py
- ERROR [expected PASS] subtest: test_always_captures_top_browsing_context
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_source_origin[same_origin]
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_source_origin[cross_origin]
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```

Stable unexpected results that are known to be intermittent (16)

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /beacon/beacon-basic.https.window.html (#41723)
- PASS [expected FAIL] subtest: Payload size restriction should be accumulated: type = string
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = arraybuffer
```
assert_false: expected false got true
```
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(kai)
```
assert_equals: quoted generic(kai) matches  @font-face rule expected 50 but got 30
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(nastaliq)
```
assert_equals: quoted generic(nastaliq) matches  @font-face rule expected 50 but got 30
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
TIMEOUT /fetch/metadata/generated/css-images.https.sub.tentative.html (#42229)
- FAIL [expected PASS] subtest: content sec-fetch-site - Cross-Site -> Same-Site
```
assert_unreached: Reached unreachable code
```
OK [expected ERROR] /fetch/metadata/window-open.https.sub.html (#40339)
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored
```
assert_equals: expected "?pass" but got "?fail"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;input autofocus=""&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

promise_test: Unhandled rejection with value: object "TypeError: can't access property "appendChild", w.document.querySelector(...) is null"

TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/src_object_blob.html (#40340)
- TIMEOUT [expected PASS] subtest: HTMLMediaElement.srcObject blob
```
Test timed out
```
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- TIMEOUT [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
```
Test timed out
```
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

github-actions · 2026-03-03T18:11:11Z

✨ Try run (#22634334160) succeeded.

gterzian

LGTM with a note to address.

gterzian · 2026-03-04T15:38:44Z

+                    // IndexedDB §5.8 Step 3: "or 0 (zero) if database was newly created."
+                    // IndexedDB §5.8 Step 4: "or the empty set if database was newly created."
+                    if let Some(db) = self.databases.remove(&key) {
+                        let _ = db.delete_database();


gterzian · 2026-03-04T15:42:12Z

-                    // Invariant: aborted initial upgrades must not remain as version-0 databases.
-                    self.databases.remove(&key);
+                    // IndexedDB §5.8 Step 3: "or 0 (zero) if database was newly created."
+                    // IndexedDB §5.8 Step 4: "or the empty set if database was newly created."


So the spec says to set the objects stores to the empty set, why are we deleting the database here? Please add a note explaining.

Sorry for late comment, but @gterzian asked a very good question. The spec doesn't suggest to delete the database. I checked at least Firefox and it leaves sqlite database on disk.

Safari seems to leave the database as well (at least according to its dev tools). However, the database doesn't show up in dev tools in Chrome (after aborting the version change transaction). This might be worth filing a spec issue to clarify behavior?

I deleted it initially because I took a too strong interpretation of rollback(I thought make sense), I was trying to guarantee “initial upgrade abort behaves like pre creation state” (version 0, no stores, and no entry in indexedDB.databases()), and since Servo creates the SQLite DB at open, deleting the DB directory was the simplest way to force that state, I will undo this and created spec issue.

created w3c/IndexedDB#491 for spec

…#42998) Abort pending upgrade requests when a worker closes, correctly roll back newlyy created databases by deleting backend state on old_version == 0. Testing: IndexedDB/worker-termination-aborts-upgrade.window.js.ini test pass. part of #40983 --------- Signed-off-by: Taym Haddadi <[email protected]>

Signed-off-by: Taym Haddadi <[email protected]>

jdm · 2026-03-19T03:34:21Z

@Taym95 It's the same two IDB tests failing in every merge attempt. What are you hoping will happen?

Taym95 · 2026-03-19T10:13:27Z

@Taym95 It's the same two IDB tests failing in every merge attempt. What are you hoping will happen?

I am confused used to pass, I will have another look today

Signed-off-by: Taym Haddadi <[email protected]>

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 3, 2026

Taym95 added the T-linux-wpt Do a try run of the WPT label Mar 3, 2026

Taym95 requested review from gterzian and janvarga March 3, 2026 16:25

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Mar 3, 2026

Taym95 added the T-linux-wpt Do a try run of the WPT label Mar 3, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Mar 3, 2026

gterzian approved these changes Mar 4, 2026

View reviewed changes

servo-highfive added S-needs-rebase There are merge conflict errors. S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Mar 4, 2026

Taym95 enabled auto-merge March 4, 2026 21:42

Taym95 added this pull request to the merge queue Mar 4, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 4, 2026

Taym95 removed this pull request from the merge queue due to a manual request Mar 4, 2026

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 4, 2026

Taym95 added this pull request to the merge queue Mar 5, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 5, 2026

Taym95 mentioned this pull request Mar 5, 2026

Clarify post abort state of newly created DB in 5.8 (physical persistence vs observable state) w3c/IndexedDB#491

Open

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 5, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 17, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 17, 2026

indexeddb: abort pending worker upgrade and delete new db on rollback

784fde7

Signed-off-by: Taym Haddadi <[email protected]>

Taym95 force-pushed the indexeddb-fix-worker-abort-upgrade-queue branch from 0181d24 to 65145f4 Compare March 18, 2026 14:37

servo-highfive removed the S-tests-failed The changes caused existing tests to fail. label Mar 18, 2026

Taym95 enabled auto-merge March 18, 2026 14:37

Taym95 added this pull request to the merge queue Mar 18, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 18, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 18, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 18, 2026

Taym95 added this pull request to the merge queue Mar 18, 2026

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 18, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 18, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 18, 2026

Taym95 added this pull request to the merge queue Mar 18, 2026

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Mar 18, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 18, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Mar 18, 2026

Add a note explaining delete_database

f22c5d7

Signed-off-by: Taym Haddadi <[email protected]>

Taym95 force-pushed the indexeddb-fix-worker-abort-upgrade-queue branch from 65145f4 to f22c5d7 Compare April 3, 2026 22:18

servo-highfive removed the S-tests-failed The changes caused existing tests to fail. label Apr 3, 2026

Taym95 enabled auto-merge April 3, 2026 22:19

Uh oh!

Conversation

Taym95 commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

gterzian left a comment

Choose a reason for hiding this comment

Uh oh!

gterzian Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

gterzian Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

janvarga Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

janvarga Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Taym95 Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Taym95 Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jdm commented Mar 19, 2026

Uh oh!

Taym95 commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Taym95 Mar 5, 2026 •

edited

Loading