devtools: Use actual class name in ObjectActor#42994
Merged
Merged
Conversation
Member
Author
class name is ObjectActor was harcoded to `Window`, this change remove the hardcoded value and replaces it with actual class name Signed-off-by: atbrakhi <[email protected]>
atbrakhi
force-pushed
the
use_class_instead_window
branch
from
33e4d48 to
ee2147f
Compare
servo-highfive
added
the
S-awaiting-review
eerii
approved these changes
Mar 3, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
Class name in `ObjectActor` was harcoded to `Window`, which is wrong. This change removes the hardcoded value and replaces it with actual class name. **Before:** <img width="320" height="163" alt="image" src="https://github.com/user-attachments/assets/f94df58a-5309-4fd1-bb02-aa06dfeb32c3" /> **After:** <img width="353" height="138" alt="image" src="https://github.com/user-attachments/assets/ad129676-8c3d-48e2-a543-1447c75c40f0" /> Testing: Existing test passes Fixes: part of servo#36027 Depends on servo#42936 Signed-off-by: atbrakhi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class name in
ObjectActorwas harcoded toWindow, which is wrong. This change removes the hardcoded value and replaces it with actual class name.Before:
After:
Testing: Existing test passes
Fixes: part of #36027
Depends on #42936