OHOS CI: Fix resident-smaps recording#42985
Merged
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
Narfinger
force-pushed
the
fix-hitrace-memory
branch
from
9bb448d to
9824ebb
Compare
jschwe
reviewed
Mar 3, 2026
Narfinger
force-pushed
the
fix-hitrace-memory
branch
from
9824ebb to
ce54926
Compare
Contributor
Author
|
As discussed: #42992 |
Signed-off-by: Narfinger <[email protected]>
jschwe
approved these changes
Mar 3, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the move of the reporting function to update_user_interface_state and the multiple events of LoadStatus::Complete, the previous reporting did not work correctly anymore.
This fixes it by manually summing up the reports for 'resident-according-to-smaps' and using the hitrace-bencher point_filter_type Largest.
This should restore the bencher graph.
Signed-off-by: Narfinger [email protected]
Testing: No automatic test but manual test here: https://github.com/Narfinger/servo/actions/runs/22617931816