script: Resolve name referencing issue during ML-DSA export#42984
Merged
Conversation
In the WebCrypto modern algorithm specification, the issue (WICG/webcrypto-modern-algos#47) on algorithm name referencing in the export key operation of ML-KEM had been resolved by the following commit in the specification repository: WICG/webcrypto-modern-algos@705f8ec Our implementation actually matches the new specification. We simply update the specification text, with some minor refactoring accordingly. This is equivalent the changes on ML-KEM in 42918 in which I forgot to include the counterpart for ML-DSA :( Testing: Refactoring. Existing tests suffice. Signed-off-by: Kingsley Yung <[email protected]>
servo-highfive
added
the
S-awaiting-review
TimvdLippe
approved these changes
Mar 3, 2026
servo-highfive
removed
the
S-awaiting-review
mrobinson
approved these changes
Mar 3, 2026
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
offline-ant
pushed a commit
to offline-ant/havi
that referenced
this pull request
Jun 4, 2026
) In the WebCrypto modern algorithm specification, the issue (WICG/webcrypto-modern-algos#47) on algorithm name referencing in the export key operation of ML-KEM had been resolved by the following commit in the specification repository: WICG/webcrypto-modern-algos@705f8ec Our implementation actually matches the new specification. We simply update the specification text, with some minor refactoring accordingly. This is equivalent the changes on ML-KEM in servo#42918 in which I forgot to include the counterpart for ML-DSA :( Testing: Refactoring. Existing tests suffice. Signed-off-by: Kingsley Yung <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the WebCrypto modern algorithm specification, the issue (WICG/webcrypto-modern-algos#47) on algorithm name referencing in the export key operation of ML-KEM had been resolved by the following commit in the specification repository:
WICG/webcrypto-modern-algos@705f8ec
Our implementation actually matches the new specification. We simply update the specification text, with some minor refactoring accordingly.
This is equivalent the changes on ML-KEM in #42918 in which I forgot to include the counterpart for ML-DSA :(
Testing: Refactoring. Existing tests suffice.